Skip to content

Remove the QDN relay mode setting #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuickMythril merged 2 commits into from
Jul 20, 2026
Merged

Remove the QDN relay mode setting #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c74eea
Remove QDN relay mode setting
QuickMythril Jul 20, 2026
5332979
Clarify always-on QDN relay scope
QuickMythril Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,5 @@ Editable settings:
`SETTING_ORDER` in `src/settingsView.ts`. The editable section is a pulled-out
view of the original full settings order, not an appended allowlist.
- `minDataPeers` is editable when the active Core reports it as writable.
- QDN relaying is unconditional whenever QDN is enabled in Qortium, so the
inherited `relayModeEnabled` switch is intentionally not editable.
3 changes: 3 additions & 0 deletions src/settingsEditor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
getTransportSelectionValue,
normalizeEditableSettingValue,
patchHasRestartRequiredSettings,
PHASE_1_EDITABLE_SETTING_KEYS,
parseGigabytesToBytes,
parseHoursToMilliseconds,
} from './settingsEditor';
Expand Down Expand Up @@ -130,6 +131,8 @@ describe('settings editor helpers', () => {
expect(canEditSetting('storagePolicy', metadata, true, true)).toBe(false);
expect(canEditSetting('qdnEnabled', metadata, true, false)).toBe(false);
expect(canEditSetting('apiLoggingEnabled', metadata, true, false)).toBe(false);
expect(canEditSetting('relayModeEnabled', metadata, true, false)).toBe(false);
expect(PHASE_1_EDITABLE_SETTING_KEYS).not.toContain('relayModeEnabled');
});

it('detects restart-required settings in a patch', () => {
Expand Down
2 changes: 0 additions & 2 deletions src/settingsEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export const PHASE_1_EDITABLE_SETTING_KEYS = [
'maxStorageCapacity',
'publicDataEnabled',
'privateDataEnabled',
'relayModeEnabled',
'qdnPushOnPublishEnabled',
'apiDocumentationEnabled',
'chatMessageRetentionPeriod',
Expand Down Expand Up @@ -90,7 +89,6 @@ const BOOLEAN_DEFAULTS: Record<BooleanEditableSettingKey, boolean> = {
publicDataEnabled: true,
qdnEnabled: true,
qdnPushOnPublishEnabled: true,
relayModeEnabled: true,
};

export function isPhase1EditableSetting(key: string): key is Phase1EditableSettingKey {
Expand Down
1 change: 0 additions & 1 deletion src/settingsView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ const SETTING_ORDER: Record<string, SettingOrder> = {
publicDataEnabled: { group: 2, priority: 20 },
privateDataEnabled: { group: 2, priority: 21 },
directDataRetrievalEnabled: { group: 2, priority: 30 },
relayModeEnabled: { group: 2, priority: 31 },
gatewayEnabled: { group: 2, priority: 40 },
gatewayLoopbackEnabled: { group: 2, priority: 41 },
gatewayLoggingEnabled: { group: 2, priority: 42 },
Expand Down