Allow overriding model download URL via LAMBEQ_MODELS_URL - #259
Open
iwang-1 wants to merge 1 commit into
Open
Conversation
The hardcoded qnlp.cambridgequantum.com host is unreachable (issues Quantinuum#253, Quantinuum#254, Quantinuum#257), so BobcatParser/OncillaParser fail on a fresh install. Read the base URL from the LAMBEQ_MODELS_URL environment variable when set (defaulting to the existing value), letting users point at a mirror or updated host without waiting for a release.
iwang-1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #253, #254, #257.
The model download host is hardcoded to
qnlp.cambridgequantum.com, which is no longer reachable, soBobcatParser()/OncillaParser()fail on a fresh install.This reads the base URL from a new
LAMBEQ_MODELS_URLenvironment variable when set, defaulting to the existing value. Users can point at a mirror or the updated host without waiting for a release.get_url()reads the variable at call time; a trailing slash is handled. Adds two tests.Happy to also update the default URL directly if a maintainer can share the current model-hosting location.