fix: use Jimeng request key for task polling - #5294
Conversation
WalkthroughThe change persists provider-specific request keys in task properties, resolves Jimeng request keys from request context, and includes upstream task and model metadata in polling requests. ChangesUpstream request key persistence and resolution
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Following up in case this fell through. This PR is focused on #5278: Jimeng task polling now uses the request key returned by task creation, with coverage for the polling path. Checks are green. Happy to adjust the key-selection behavior if you prefer a different source of truth. |
984aa23 to
9ec62e4
Compare
Summary
Persist the Jimeng request key produced during task submission and pass it through asynchronous polling. This keeps submission and result queries on the same provider key, including v30 model variants and metadata overrides.
Tasks created before this field existed continue to use the existing default or best-effort model/action fallback.
Closes #5278
Tests
go test ./relay/channel/task/jimeng -count=1go test ./service -count=1go test ./model -run 'Task|InitTask' -count=1git diff --checkSummary by CodeRabbit