Searching relay runners by Bib, when using assign card to runner. - #1198
Open
VojtechVelat wants to merge 1 commit into
Open
Searching relay runners by Bib, when using assign card to runner.#1198VojtechVelat wants to merge 1 commit into
VojtechVelat wants to merge 1 commit into
Conversation
fvacek
requested changes
Aug 13, 2026
Collaborator
There was a problem hiding this comment.
should not be part of commit IMO
| .joinRestricted("competitors.id", "runs.competitorId", "runs.stageId=" QF_IARG(stage_id), "JOIN") | ||
| .orderBy("classes.name, lastName, firstName"); | ||
| if(is_relays) { | ||
| qb.select("relays.number AS \"competitors.startNumber\"") |
Collaborator
There was a problem hiding this comment.
Suggested change
| qb.select("relays.number AS \"competitors.startNumber\"") | |
| qb.select("relays.number AS startNumber") |
| .join("relays.classId", "classes.id"); | ||
| } | ||
| else { | ||
| qb.select2("competitors", "startNumber") |
Collaborator
There was a problem hiding this comment.
Suggested change
| qb.select2("competitors", "startNumber") | |
| qb.select("competitors.startNumber AS startNumber") |
Collaborator
|
I see that another feature has been added - displaying the start number and leg in the Card Readout. 
|
Collaborator
|
Thanks for this PR. It helps with relays. |
fvacek
self-requested a review
August 25, 2026 18:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When organizing a relay it is not possible to search runners by Bib, when using the "assign card to runner". All bibs default to 0.
This commit fixes this problem.
