Fix probationary Observe delivery and quiesced cleanup - #71
Merged
QuiteYellow merged 1 commit intoAug 29, 2026
Merged
Conversation
This was referenced Aug 29, 2026
Jason-Morcos
force-pushed
the
codex/observe-lifecycle-followups
branch
from
August 29, 2026 17:58
a11e493 to
eadb2f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
2.05throughon_notificationwhile the Observe relation remains probationary.quiesce_for_close()so the later orderlyclose()can pace exact deregistration requests before close-notify.Why
This follows up on the post-merge findings in #67, #68, and #69.
Some appliances answer an Observe registration once without an Observe option and may never send a second packet. The first representation is still useful state, but it should not falsely confirm a lasting relation. This keeps those two decisions separate: the payload is delivered, while the relation remains probationary until a later different-MID packet proves the legacy behavior.
The two-phase shutdown path also needs the same explicit observer cleanup as a direct
close().quiesce_for_close()remains the immediate signal that wakes waiters and stops application work. It additionally retains the relation metadata needed for cleanup; after workers have joined,close()uses a teardown-only paced send path for deregistration and then flushes close-notify. Ordinary requests remain rejected after quiescence.Validation