Fix alpha.5 release SSH regression - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0.1.0-alpha.6(10006)Why
Alpha.5 installed successfully over alpha.4 but every SSH connection failed before authentication. sshlib 0.4.2 constructs its bundled Ed25519 provider during host-key verification. R8 moved that provider into the default package, causing the provider's runtime package lookup to return null.
Impact
The narrow keep rule restores Ed25519 host-key verification in the minified release. Alpha.6 still requires permanent signing and physical update acceptance before tester distribution.
Validation
./gradlew --no-daemon test lint assembleDebug assembleRelease connectedDebugAndroidTest