Fix PHY collision mesh importing flipped - #474
Open
atirna wants to merge 1 commit into
Open
Conversation
Remove the Y/Z axis swap in CollisionModel.get_vertex_data so decoded collision vertices keep the same Source1 XYZ order the visual mesh importers already use. Fixes REDxEYE#290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I changed PHY collision vertex decoding to preserve the Source1 XYZ coordinate order. Previously the decoder exchanged Y and Z before mesh creation, mirroring the collision mesh against the visual model.
Fixes #290
Why
Collision geometry needs the same coordinate order as the visual model it represents. The mdl49 and mdl52 visual importers already pass decoded VVD coordinates straight into
Mesh.from_pydata, so the PHY-only swap was the odd one out.Verification
master: raw PHY vertex floats1, 2, 3fed throughCollisionModel.get_vertex_datacame back1, 3, 2with lateral and vertical swapped1, 2, 3, matching the order the visual mesh importers usepython3 -m compileall -q library/models/phy/phy.py