chore: prepare release v0.3.0 #31
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| const Layout = ({ children }: { children: React.ReactNode }) => { | ||
| return ( | ||
| <div className="flex h-full min-h-screen min-w-screen flex-col items-center justify-center"> | ||
| {children} | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| export default Layout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { SignIn } from "@clerk/nextjs" | ||
|
|
||
| const Page = () => { | ||
| return <SignIn /> | ||
| } | ||
|
|
||
| export default Page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { SignUp } from "@clerk/nextjs" | ||
|
|
||
| const Page = () => { | ||
| return <SignUp /> | ||
| } | ||
|
|
||
| export default Page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,34 @@ | ||
| "use client" | ||
|
|
||
| import { | ||
| useMutation, | ||
| useQuery, | ||
| Authenticated, | ||
| Unauthenticated, | ||
| } from "convex/react" | ||
| import { api } from "@workspace/backend/_generated/api" | ||
| import { Button } from "@workspace/ui/components/button" | ||
| import { SignInButton, UserButton } from "@clerk/nextjs" | ||
|
|
||
| export default function Page() { | ||
| const users = useQuery(api.users.getMany) | ||
| const addUser = useMutation(api.users.add) | ||
| return ( | ||
| <> | ||
| <Authenticated> | ||
| <div className="flex min-h-svh flex-col items-center justify-center"> | ||
| <p> apps/web</p> | ||
| <UserButton /> | ||
| <Button onClick={() => addUser()}>Add</Button> | ||
| <div className="mx-auto w-full max-w-sm"> | ||
| {JSON.stringify(users, null, 2)} | ||
| </div> | ||
| </div> | ||
| </Authenticated> | ||
| <Unauthenticated> | ||
| <p>Must be signed In</p> | ||
| <SignInButton>Sign In!</SignInButton> | ||
| </Unauthenticated> | ||
| </> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,63 +1,22 @@ | ||
| "use client" | ||
|
|
||
| import { ConvexReactClient } from "convex/react" | ||
| import { ConvexProviderWithClerk } from "convex/react-clerk" | ||
|
|
||
| import { useAuth } from "@clerk/nextjs" | ||
|
|
||
| if (!process.env.NEXT_PUBLIC_CONVEX_URL) { | ||
| throw new Error("Missing NEXT_PUBLIC_CONVEX_URL in your .env file") | ||
| } | ||
|
|
||
| const convex = new ConvexReactClient(process.env.NEXT_PUBLIC_CONVEX_URL) | ||
|
|
||
| function ThemeProvider({ children }: { children: React.ReactNode }) { | ||
| return ( | ||
| <ConvexProviderWithClerk client={convex} useAuth={useAuth}> | ||
| {children} | ||
| </ConvexProviderWithClerk> | ||
| ) | ||
| } | ||
|
|
||
| export { ThemeProvider } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||||||||||||||||||||||||||||||
| import { clerkMiddleware, createRouteMatcher } from "@clerk/nextjs/server" | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| const isPublicRoute = createRouteMatcher(["/sign-in(.*)", "/sign-up(.*)"]) | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| export default clerkMiddleware(async (auth, req) => { | ||||||||||||||||||||||||||||||||||
| if (!isPublicRoute(req)) { | ||||||||||||||||||||||||||||||||||
| await auth.protect() | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+3
to
+8
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Make
Suggested fix-const isPublicRoute = createRouteMatcher(["/sign-in(.*)", "/sign-up(.*)"])
+const isPublicRoute = createRouteMatcher([
+ "/",
+ "/sign-in(.*)",
+ "/sign-up(.*)",
+])📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||
| }) | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| export const config = { | ||||||||||||||||||||||||||||||||||
| matcher: [ | ||||||||||||||||||||||||||||||||||
| // Skip Next.js internals and all static files, unless found in search params | ||||||||||||||||||||||||||||||||||
| "/((?!_next|[^?]*\\.(?:html?|css|js(?!on)|jpe?g|webp|png|gif|svg|ttf|woff2?|ico|csv|docx?|xlsx?|zip|webmanifest)).*)", | ||||||||||||||||||||||||||||||||||
| // Always run for API routes | ||||||||||||||||||||||||||||||||||
| "/(api|trpc)(.*)", | ||||||||||||||||||||||||||||||||||
| ], | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Clarify the
CLERK_JWT_ISSUER_DOMAINsetup note.The table states that
packages/backend/.env.localis "auto-generated byconvex dev", butCLERK_JWT_ISSUER_DOMAINis not auto-generated — it must be manually configured from the Clerk Dashboard. OnlyCONVEX_DEPLOYMENTis automatically created byconvex dev. This could mislead developers setting up the backend.📝 Suggested clarification
📝 Committable suggestion
🤖 Prompt for AI Agents