-
Notifications
You must be signed in to change notification settings - Fork 72
[WS2][PR4][Logp] feat: add distributed TP/CP logprob drift report #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hihaluemen
wants to merge
29
commits into
RL-Align:test
Choose a base branch
from
hihaluemen:feat/ws2-logprob-distributed-report-pr4
base: test
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,755
−38
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b7ffb3a
feat(ws2): add TP-aware logprob contract and dispatch metadata
ryankert01 cdc11ba
fix(ws2): address CodeRabbit review on logprob contract PR
ryankert01 6455715
fix(ws2): address second CodeRabbit round on logprob contract
ryankert01 3b4eaef
feat(ws2): make determinism scope and invocation surface part of the …
ryankert01 e6dbeef
docs(ws2): drop standalone design doc per review
ryankert01 878ba88
style(ws2): align comment density with sibling kernel modules
ryankert01 934bc5b
feat: add single-gpu logprob comparison harness
hihaluemen b69426d
fix: keep logprob CLI stdout machine readable
hihaluemen 0efcfe1
refactor: simplify logprob comparison harness
hihaluemen 115d86c
docs: document SM90 logprob validation
hihaluemen c028b5b
fix: address logprob harness lint and provenance
hihaluemen 7ba09b5
fix: type heterogeneous logprob backends
hihaluemen 4231625
fix comment
KJLdefeated 2360a71
test(ws2): align dispatch tests with the auto+TP>1 unsafe-dispatch guard
KJLdefeated 99e59f8
Merge branch 'RL-Align:main' into feat/ws2-logprob-single-gpu-harness…
hihaluemen 4eebb3b
refactor: colocate logprob harness tooling and docs
hihaluemen 19488cc
test: resolve logprob CLI path reliably
hihaluemen 6e2a79e
Merge PR1 logprob contract into PR2 integration base
hihaluemen b7d9d89
init vocab parallel logp
KJLdefeated 3866d3c
init vocab parallel logp
KJLdefeated 65f3c6f
adding cross tp testing
KJLdefeated 05d19eb
test: align PR3 dispatch with latest PR1 guard
hihaluemen a46891a
Merge branch 'RL-Align:main' into feat/ws2-logprob-single-gpu-harness…
hihaluemen 57b04b1
Merge latest PR2 into PR1-PR3 integration base
hihaluemen f36a63d
feat(ws2): add distributed logprob drift runner
hihaluemen 1d9bac1
ci(ws2): run logprob comparison tests
hihaluemen f6b5a07
fix(ws2): harden distributed drift reporting
hihaluemen 8a4f4be
fix(ws2): clean up process groups on setup failure
hihaluemen c2c99c1
feat(ws2): record cross-topology logprob fingerprints
hihaluemen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.