WP-419 adst callers can set site depth and override the decomposition rate (k) - #40
Open
HughRunyan wants to merge 2 commits into
Open
WP-419 adst callers can set site depth and override the decomposition rate (k)#40HughRunyan wants to merge 2 commits into
HughRunyan wants to merge 2 commits into
Conversation
Restore the last two City.sdst_v1_5 site-DST levers that adst had no equivalent for. Both are opt-in and default to None (derive exactly as before), so existing adst calls are byte-for-byte unchanged. - depth (Variant[float], metres): a controlled/open dump (type 1/2) deeper than 5 m has its MCF raised to 0.8, matching City.sdst_v1_5. Implemented in dst_common.mcf_series via optional per-variant baseline/scenario depth; never applies to engineered landfills (type 0). - k_override (Variant[YearlyFloat]): a caller-supplied decomposition rate applied uniformly to all five biodegradable components, bypassing the derived (temperature/precipitation/composition) k. New helper dst_common.uniform_decomposition_rates. Changelog: changelog/2026-08.md (Added). Not a model-output change for existing calls. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
11 tasks
HughRunyan
changed the title
andrewmilligan
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single-site advanced DST (
adst) gains two optional inputs that restore the last twoCity.sdst_v1_5(site-DST) levers the adst model had no equivalent for. Both are opt-in and default to today's derived behavior.User story: As a
/sdstuser migrating to theadstendpoint, I want to set a site's depth and override the decomposition rate (k), so that the newer endpoint reproduces the full modeling the current tool exposes.What changed
AdvancedDSTRequest.depth(Optional[Variant[float]], metres): a controlled/open dump (type 1 or 2) deeper than 5 m has its MCF raised to 0.8 (deep dumps decompose more anaerobically), matchingCity.sdst_v1_5. Implemented indst_common.mcf_series, which now takes optional per-variantbaseline_depth/scenario_depth; never applies to engineered landfills (type 0).AdvancedDSTRequest.k_override(Optional[Variant[YearlyFloat]]): a caller-suppliedkapplied uniformly to all five biodegradable components, bypassing the derived (temperature/precipitation/composition) k — mirroringCity.sdst_v1_5'sks_overrides. New helperdst_common.uniform_decomposition_rates.implement_yearlike every other adst input.Not a model-output change
Both fields default to
None= derive exactly as before, so every existing adst call is byte-for-byte unchanged. Output only changes when a caller opts in. Changelog entry is filed under Added (notmodel-output-change).Acceptance criteria
depth> 5 m on a dump raises MCF to 0.8; ≤ 5 m and engineered landfills (type 0) are unaffected.k_overridebypasses the derived k and applies to all five degradable components.changelog/2026-08.md).Definition of Done
Acceptance criteria met · tests pass (13/13 adst, 59/59 fast suite) · changelog updated · reviewed & merged.
Related
Tests + endpoint verification live in RMI/WasteMAP#724 on the same branch name (
adst-depth-k-override), so WasteMAP CI installs this SWEET_python branch. Merge that PR alongside this one.🤖 Generated with Claude Code