Skip to content

ci: use RMI central rulesets check - #929

Merged
AlexAxthelm merged 2 commits into
mainfrom
feat/rulesets-check
Aug 27, 2026
Merged

ci: use RMI central rulesets check#929
AlexAxthelm merged 2 commits into
mainfrom
feat/rulesets-check

Conversation

@AlexAxthelm

Copy link
Copy Markdown
Collaborator

Summary

Use the new centrall managed rulesets check from RMI/actions#10

Checklist

  • PR is focused on a single concern
  • Tests pass locally and in CI
  • Docs updated for user-visible changes
  • AI-assisted portions declared (see CONTRIBUTING.md)

Copilot AI lite review requested due to automatic review settings August 27, 2026 09:54
@AlexAxthelm AlexAxthelm self-assigned this Aug 27, 2026
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Expected version change and release notes:

1.16.0-dev.23 (v1.16.0-dev.22...feat/rulesets-check ) (2026-08-27T10:36 UTC)

Continuous Integration and Delivery (CI/CD)

  • use RMI central rulesets check (af2e68a)

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-929.westus2.2.azurestaticapps.net

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the repository’s GitHub rulesets drift check to use the centrally maintained RMI/actions rulesets-check action, and switches the repo’s ruleset definitions from full exported JSON to small overlay files that reference shared templates.

Changes:

  • Replace the bespoke gh api + jq + diff ruleset comparison logic with RMI/actions/actions/admin/rulesets-check@main.
  • Convert ruleset definitions from full exported *.json to template-based *.overlay.json files (and remove the old exports).
  • Update .github/rulesets/README.md to document the new overlay/template workflow.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/admin-check_rulesets.yml Uses the centrally managed rulesets-check action and declares minimal token permissions.
.github/rulesets/README.md Documents overlay/template semantics and the new CI check behavior.
.github/rulesets/gitflow-production.overlay.json Adds overlay-based definition for production ruleset (template + per-repo required checks).
.github/rulesets/gitflow-production.json Removes legacy full exported ruleset JSON.
.github/rulesets/gitflow-next-pr.overlay.json Adds template-only overlay for next PR ruleset.
.github/rulesets/gitflow-next-pr.json Removes legacy full exported ruleset JSON.
.github/rulesets/gitflow-next-lifecycle.overlay.json Adds overlay for next lifecycle ruleset with explicit branch conditions.
.github/rulesets/gitflow-next-lifecycle.json Removes legacy full exported ruleset JSON.
.github/rulesets/gitflow-main.overlay.json Adds overlay-based definition for main ruleset required checks.
.github/rulesets/gitflow-main.json Removes legacy full exported ruleset JSON.
.github/rulesets/code-quality-copilot-review.overlay.json Updates to overlay format using the blank template for the non-shared ruleset.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/rulesets/README.md
Copilot AI review requested due to automatic review settings August 27, 2026 10:35
@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-929.westus2.2.azurestaticapps.net

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

Suppressed comments (3)

Previously missed (2) — in code that hasn't changed since the last review.

.github/workflows/admin-check_rulesets.yml:27

  • The inline note about token permissions is inaccurate: GITHUB_TOKEN can be granted administration permissions via the workflow permissions block. Suggest rewording this comment to avoid implying the permission doesn't exist.
    # Explicit rather than relying on the repo/org default token permissions.
    # NOTE: GITHUB_TOKEN has no `administration` scope; the ruleset read works
    # with the default read grants, so contents:read is the minimal useful
    # declaration here (checkout below).

.github/workflows/admin-check_rulesets.yml:36

  • Using an external action pinned to @main makes the workflow non-reproducible and increases supply-chain risk (the behavior can change without changes in this repo). Prefer pinning to a version tag or a specific commit SHA.
      # Calls the centrally-maintained composite action in RMI/actions.
      - uses: RMI/actions/actions/admin/rulesets-check@main

.github/rulesets/README.md:5

  • The opening paragraph reads like a sentence break/run-on ("...Rulesets ... this repo expects..."). Consider rephrasing into a single clear sentence so the README renders cleanly.
This directory defines the [GitHub Rulesets](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/about-rulesets)
this repo expects to be in effect. CI compares them against the repo's **live**
rulesets and fails if they drift.

@AlexAxthelm
AlexAxthelm marked this pull request as ready for review August 27, 2026 11:34

@jacobvjk jacobvjk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexAxthelm
AlexAxthelm merged commit 9f9c68c into main Aug 27, 2026
13 checks passed
@AlexAxthelm
AlexAxthelm deleted the feat/rulesets-check branch August 27, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants