ci: use RMI central rulesets check - #929
Conversation
Expected version change and release notes:1.16.0-dev.23 (v1.16.0-dev.22...feat/rulesets-check ) (2026-08-27T10:36 UTC)Continuous Integration and Delivery (CI/CD)
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-929.westus2.2.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s GitHub rulesets drift check to use the centrally maintained RMI/actions rulesets-check action, and switches the repo’s ruleset definitions from full exported JSON to small overlay files that reference shared templates.
Changes:
- Replace the bespoke
gh api+jq+diffruleset comparison logic withRMI/actions/actions/admin/rulesets-check@main. - Convert ruleset definitions from full exported
*.jsonto template-based*.overlay.jsonfiles (and remove the old exports). - Update
.github/rulesets/README.mdto document the new overlay/template workflow.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/admin-check_rulesets.yml | Uses the centrally managed rulesets-check action and declares minimal token permissions. |
| .github/rulesets/README.md | Documents overlay/template semantics and the new CI check behavior. |
| .github/rulesets/gitflow-production.overlay.json | Adds overlay-based definition for production ruleset (template + per-repo required checks). |
| .github/rulesets/gitflow-production.json | Removes legacy full exported ruleset JSON. |
| .github/rulesets/gitflow-next-pr.overlay.json | Adds template-only overlay for next PR ruleset. |
| .github/rulesets/gitflow-next-pr.json | Removes legacy full exported ruleset JSON. |
| .github/rulesets/gitflow-next-lifecycle.overlay.json | Adds overlay for next lifecycle ruleset with explicit branch conditions. |
| .github/rulesets/gitflow-next-lifecycle.json | Removes legacy full exported ruleset JSON. |
| .github/rulesets/gitflow-main.overlay.json | Adds overlay-based definition for main ruleset required checks. |
| .github/rulesets/gitflow-main.json | Removes legacy full exported ruleset JSON. |
| .github/rulesets/code-quality-copilot-review.overlay.json | Updates to overlay format using the blank template for the non-shared ruleset. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-929.westus2.2.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
Suppressed comments (3)
Previously missed (2) — in code that hasn't changed since the last review.
.github/workflows/admin-check_rulesets.yml:27
- The inline note about token permissions is inaccurate:
GITHUB_TOKENcan be grantedadministrationpermissions via the workflowpermissionsblock. Suggest rewording this comment to avoid implying the permission doesn't exist.
# Explicit rather than relying on the repo/org default token permissions.
# NOTE: GITHUB_TOKEN has no `administration` scope; the ruleset read works
# with the default read grants, so contents:read is the minimal useful
# declaration here (checkout below).
.github/workflows/admin-check_rulesets.yml:36
- Using an external action pinned to
@mainmakes the workflow non-reproducible and increases supply-chain risk (the behavior can change without changes in this repo). Prefer pinning to a version tag or a specific commit SHA.
# Calls the centrally-maintained composite action in RMI/actions.
- uses: RMI/actions/actions/admin/rulesets-check@main
.github/rulesets/README.md:5
- The opening paragraph reads like a sentence break/run-on ("...Rulesets ... this repo expects..."). Consider rephrasing into a single clear sentence so the README renders cleanly.
This directory defines the [GitHub Rulesets](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/about-rulesets)
this repo expects to be in effect. CI compares them against the repo's **live**
rulesets and fails if they drift.
Summary
Use the new centrall managed rulesets check from RMI/actions#10
Checklist