Feat/UI tabs - #936
Draft
AlexAxthelm wants to merge 6 commits into
Draft
Conversation
Split the single scrolling pathway detail page into a four-tab layout (At a glance / Overview / Timeseries / Scope & Granularity) per Jacob's wireframe, with a sticky sector + tab bar that persists on scroll. - Add an accessible Tabs/TabPanel primitive (WAI-ARIA tabs pattern: roving tabindex, Arrow/Home/End keys, aria-selected/controls wiring). - Back the active tab with a `?tab=` query param via a useActiveTab hook so tabs are deep-linkable, shareable, and survive reload/back. The URL mechanism is isolated behind the hook for a cheap later swap to path segments. - Move existing v1 content into tabs: At a glance (Expert Overview, plot, Key Features, coverage panels), Timeseries (Supplemental Info + plot). - Render labeled placeholders for the wireframe sections that need the metadata-v2 schema (#898): Assumptions & Trends, Dependencies, and the Data Availability table. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Render the pathway's dependencies (conditions its outcomes rely on) as a table in the Overview tab, replacing the placeholder. Columns: Dependency, Evidence type (a strength-colored badge), and Constraint. A Sector column is shown only when the rows span more than one sector, so single-sector pathways match the three-column wireframe. An empty dependency list renders an explanatory empty state, since authoring is incremental. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Render coreDrivers as the Assumptions & Trends Overview in the Overview tab, replacing the last placeholder: one card per driver (Policies, Emissions targets, Technology costs, Investment, Macroeconomic drivers, Behavioral shifts, Other drivers). A null driver is shown as an explicit "not a core driver for this pathway" note rather than hidden, matching the schema's distinction between an absent driver and an undescribed one. Drops the now-unused SectionPlaceholder. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Mount PathwayDetailPage with a complete v2 fixture and assert each section routes to the right tab: Expert Overview on At a glance, coreDrivers + dependencies on Overview, dataAvailability on Scope & Granularity, plus deep-linking via ?tab=. Kept in its own file for mergeability. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
Closes:
Testing
Checklist