Skip to content

github: add daily TheRock dependency update workflow - #243

Open
lumachad wants to merge 1 commit into
amd-stagingfrom
users/lumachad/amd-staging/github/therock-deps-daily
Open

github: add daily TheRock dependency update workflow#243
lumachad wants to merge 1 commit into
amd-stagingfrom
users/lumachad/amd-staging/github/therock-deps-daily

Conversation

@lumachad

@lumachad lumachad commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Adds a workflow intended to run twice daily (03:17 and 15:17 UTC) to bump THEROCK_COMMIT_REF and the therock_build_manylinux_x86_64 container digest in therock-ci-linux.yml. If an open PR labelled therock-deps already exists, the run skips cleanly.

The schedule is currently commented out for testing; the workflow can be triggered manually via workflow_dispatch in the meantime.

The build container digest is fetched via the OCI Distribution API using Python's stdlib urllib, avoiding any external tool dependency. The TheRock commit is resolved against refs/heads/main explicitly rather than relying on HEAD.

@lumachad lumachad self-assigned this Aug 4, 2026
@lumachad
lumachad requested a review from a team as a code owner August 4, 2026 07:49
@lumachad
lumachad marked this pull request as draft August 4, 2026 07:50
@lumachad
lumachad marked this pull request as ready for review August 4, 2026 10:05
@lumachad lumachad assigned spatrang and unassigned lumachad Aug 4, 2026

@lancesix lancesix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick pass, with some minor remarks.

Comment thread .github/scripts/update_therock_deps.py Outdated
Comment thread .github/scripts/update_therock_deps.py Outdated
Comment thread .github/workflows/therock-deps-update.yml Outdated
@lumachad
lumachad force-pushed the users/lumachad/amd-staging/github/therock-deps-daily branch from dbd6ff7 to 99c74d0 Compare August 4, 2026 15:08
@lumachad
lumachad requested a review from lancesix August 4, 2026 15:10
@lumachad
lumachad force-pushed the users/lumachad/amd-staging/github/therock-deps-daily branch 2 times, most recently from 674698d to 7d22849 Compare August 6, 2026 07:16
Comment thread .github/workflows/therock-deps-update.yml Outdated
Comment thread .github/workflows/therock-deps-update.yml
Comment thread .github/workflows/therock-deps-update.yml
Comment thread .github/scripts/update_therock_deps.py Outdated
Comment thread .github/scripts/update_therock_deps.py Outdated
@spatrang spatrang assigned lumachad and unassigned spatrang Aug 6, 2026
@lumachad
lumachad force-pushed the users/lumachad/amd-staging/github/therock-deps-daily branch from 7d22849 to 521fc45 Compare August 6, 2026 09:35
Adds a workflow intended to run twice daily (03:17 and 15:17 UTC) to
bump THEROCK_COMMIT_REF and the therock_build_manylinux_x86_64 container
digest in therock-ci-linux.yml.  If an open PR labelled 'therock-deps'
already exists, the run skips cleanly.

The schedule is currently commented out for testing; the workflow can be
triggered manually via workflow_dispatch in the meantime.

The build container digest is fetched via the OCI Distribution API using
Python's stdlib urllib, avoiding any external tool dependency.  The
TheRock commit is resolved against refs/heads/main explicitly rather
than relying on HEAD.

Co-Authored-By: Claude <noreply@anthropic.com>
@lumachad
lumachad force-pushed the users/lumachad/amd-staging/github/therock-deps-daily branch from 521fc45 to f21c4ef Compare August 6, 2026 09:43
@lumachad lumachad assigned spatrang and unassigned lumachad Aug 6, 2026

@spatrang spatrang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One non-blocking question below.

Comment on lines +4 to +6
# schedule: # runs twice daily (03:17 and 15:17 UTC)
# - cron: '17 3 * * *'
# - cron: '17 15 * * *'

@spatrang spatrang Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: the schedule: triggers are commented out, so the workflow is manual-only (workflow_dispatch) for now - makes sense for validating via manual runs first. Consider a brief inline note (or a tracking issue) so re-enabling the cron isn't forgotten.

@spatrang spatrang assigned lumachad and unassigned spatrang Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants