Skip to content

[ci] Fetch build and CPU test runner dynamically from therock-ci-config - #256

Draft
lumachad wants to merge 1 commit into
amd-stagingfrom
users/lumachad/amd-staging/use_runner_from_ci_config
Draft

[ci] Fetch build and CPU test runner dynamically from therock-ci-config#256
lumachad wants to merge 1 commit into
amd-stagingfrom
users/lumachad/amd-staging/use_runner_from_ci_config

Conversation

@lumachad

@lumachad lumachad commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace hardcoded azure-linux-scale-rocm in the build job with a dynamic runner label read from ROCm/therock-ci-config's runner-config.json (build_runners.linux.default, highest-weight entry).
  • Replace hardcoded aws-linux-scale-rocm-prod in the CPU test job with the same dynamic selection.
  • The setup job in therock-ci.yml checks out therock-ci-config and selects the runner via ci_config_api.py, passing it as a new build_runs_on input to therock-ci-linux.yml.
  • therock-test-packages.yml's configure_test_matrix job applies the same logic and exposes cpu_runs_on for the CPU component's test_runs_on expression.
  • Both runner-selection steps fall back to aws-linux-scale-rocm-prod if therock-ci-config is unavailable (e.g., in forks).

Test plan

  • Verify CI triggers on this PR and the build job picks up the correct runner label from therock-ci-config
  • Verify CPU test component routes to the dynamically selected runner
  • Verify GPU test component still uses the per-component runner from fetch_test_configurations.py
  • Verify fallback behaviour by temporarily breaking the ci-config checkout (continue-on-error: true already set)

🤖 Generated with Claude Code

@lumachad
lumachad requested a review from a team as a code owner August 6, 2026 15:12
@lumachad lumachad self-assigned this Aug 6, 2026
@lumachad
lumachad marked this pull request as draft August 6, 2026 15:13
@lumachad
lumachad force-pushed the users/lumachad/amd-staging/use_runner_from_ci_config branch 2 times, most recently from b9bb3bc to a43e9c2 Compare August 6, 2026 19:13
@lumachad lumachad closed this Aug 6, 2026
@lumachad
lumachad force-pushed the users/lumachad/amd-staging/use_runner_from_ci_config branch from a43e9c2 to ac936bc Compare August 6, 2026 19:15
@lumachad lumachad reopened this Aug 6, 2026
Replace hardcoded runner labels (azure-linux-scale-rocm in the build
job, aws-linux-scale-rocm-prod in the CPU test job) with dynamic
selection driven by ROCm/therock-ci-config's runner-config.json.

The setup job in therock-ci.yml now checks out therock-ci-config and
reads build_runners.linux.default, picking the highest-weight entry
via ci_config_api.py. The result is passed as build_runs_on to
therock-ci-linux.yml, which accepts it as a new workflow_call input
(with a safe fallback default).

therock-test-packages.yml applies the same logic in
configure_test_matrix to select the CPU runner dynamically, replacing
the previously hardcoded label in the test_runs_on expression.

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
@lumachad
lumachad force-pushed the users/lumachad/amd-staging/use_runner_from_ci_config branch from 73723d9 to aa7fc34 Compare August 6, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants