[CI] Parity: add rocm-preview arch - #3406
Open
ethanwee1 wants to merge 1 commit into
Open
Conversation
Adds a "preview" ROCm arch so parity can be run against the upstream rocm-preview lane (linux-noble-rocm-preview-py3.12-gfx942, gfx942), which runs the TheRock preview wheel (e.g. ROCm 7.14) via the ciflow/rocm-preview label. default/distributed/inductor all come from the single rocm-preview workflow (6/3/2 shards). - parity_job_config.json: new rocm.preview entry. - download_testlogs: allow --arch preview. - parity.yml: list preview as an arch option. Because rocm-preview is ciflow-triggered (not scheduled on main), this arch is for manual/on-demand parity runs against a rocm-preview commit; it is intentionally not added to the auto-trigger scope.
1 task
|
Jenkins build for 58cb4d0e111ca0b6ee73fac7fce8f7c05b041fea commit finished as FAILURE |
Collaborator
|
This will also benefit from the changes to look at the yaml file, so will merge this after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
previewROCm arch to the parity tooling so we can run parity against the upstreamrocm-previewlane —linux-noble-rocm-preview-py3.12-gfx942(gfx942), which runs the TheRock preview wheel (e.g. ROCm 7.14, cf. pytorch#188593) via theciflow/rocm-previewlabel.Changes
parity_job_config.json: newrocm.previewentry.default/distributed/inductorall come from the singlerocm-previewworkflow (6/3/2 shards);checkrun_regexmatcheslinux-noble-rocm-preview-py3.12-gfx942 / test (...).download_testlogs: allow--arch preview.parity.yml: listpreviewas an arch option.Notes
rocm-previewis ciflow-triggered (runs when a PR carries theciflow/rocm-previewlabel), not scheduled onmain. So this arch is for manual/on-demand parity runs against a specificrocm-previewcommit; it is intentionally not added to the auto-trigger scope. Run it as e.g.arch = preview,sha = <a ciflow/rocm-preview commit>.Test plan
arch=previewagainst arocm-previewcommit — validation run linked below.Validation
ROCm-only preview parity run (arch=preview, skip_cuda) on rocm-preview commit
51d3aca0: https://github.com/ethanwee1/pytorch/actions/runs/28885011289 — resolves all rocm-preview default/distributed/inductor data. Note: a full preview-vs-CUDA report needs a preview SHA that also has a CUDAtrunkrun; ciflow-only preview commits lack it (a same-SHA run failed with "No trunk workflow run found for CUDA tests").arch=previewsha=51d3aca0skip_cuda: https://github.com/ROCm/pytorch/actions/runs/28898344903 — setup-matrix + generate-parity(preview) + summarize all green.