[CI] Parity: classify conv2d_backward ROCm skip as PT2.0 - Convolution - #3410
Open
ethanwee1 wants to merge 2 commits into
Open
[CI] Parity: classify conv2d_backward ROCm skip as PT2.0 - Convolution#3410ethanwee1 wants to merge 2 commits into
ethanwee1 wants to merge 2 commits into
Conversation
test_conv2d_backward_parametrized is skipped on ROCm via skipIfRocmArch (upstream pytorch#188671, CI timeout). It was falling into the generic Misc bucket; add a Tier-1 rule so conv2d_backward gfx-arch skips are categorized as 'PT2.0 - Convolution' instead. Non-conv2d gfx skips stay Misc.
|
Jenkins build for b213fd93a1113d9e4cd24c9ff52a86ddc064466e commit finished as ABORTED |
| # Misc arch rule. | ||
| {"reason": "PT2.0 - Convolution", | ||
| "msg": r"test skipped on \('gfx", | ||
| "name": r"(?i)conv2d_backward"}, |
Collaborator
There was a problem hiding this comment.
please add a file regex for inductor
Add file regex per review so the PT2.0 - Convolution classification only matches conv2d_backward skips from the inductor workflow.
Author
|
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Categorizes the
test_conv2d_backward_parametrizedROCm skip (skipIfRocmArch, upstream pytorch#188671 CI timeout) as PT2.0 - Convolution inauto_classify_skip_reasons.pyinstead of the generic Misc bucket.Adds a Tier-1 rule matching
conv2d_backward+test skipped on ('gfx...')+file: ^inductor\.test_torchinductor$so only inductor-workflow conv2d backward skips are reclassified; unrelated gfx skips stay Misc.Validation
Ran
auto_classify_skip_reasons.pyover a real mi350 CSV (commita7262068):test_conv2d_backward_parametrizedand its dynamic-shapes variants classify as PT2.0 - Convolution; unrelatedskipIfRocm gfxskips still classify as Misc.