[release/2.13] [ROCm] Require libhipcxx in LoadHIP.cmake for ROCm 10+ - #3531
Draft
ethanwee1 wants to merge 1 commit into
Draft
[release/2.13] [ROCm] Require libhipcxx in LoadHIP.cmake for ROCm 10+#3531ethanwee1 wants to merge 1 commit into
ethanwee1 wants to merge 1 commit into
Conversation
ROCm 10 ships hipCUB against CCCL 3.x via libhipcxx. Call find_package(libhipcxx) from LoadHIP.cmake so ROCM_INCLUDE_DIRS includes libhipcxx headers during configure; mark REQUIRED when ROCM_VERSION_DEV >= 10.0 and keep optional on older ROCm. Urgent fix for ROCm 10 PyTorch wheel/build validation on TheRock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ROCm 10 ships hipCUB against CCCL 3.x via libhipcxx. PyTorch should resolve that dependency directly in
cmake/public/LoadHIP.cmakeviafind_package(libhipcxx)soROCM_INCLUDE_DIRSincludes libhipcxx headers at configure time.Release/2.13 already had optional
find_package(libhipcxx)from #3442; this follow-up marks it REQUIRED whenROCM_VERSION_DEV >= 10.0(optional on older ROCm).Changes
find_package_and_print_version(libhipcxx REQUIRED)onROCM_VERSION_DEV VERSION_GREATER_EQUAL "10.0".find_package(libhipcxx)on ROCm < 10.TheRock validation
Multi-Arch Build Portable Linux PyTorch Wheelsusers/ethanwee/pytorch-gitrepo-originethanwee1/pytorch@ethanwee/rocm10-libhipcxx-2.13rocm_version10.0.0a20260729rocm_package_index_urlhttps://rocm.nightlies.amd.com/whl-multi-arch/amdgpu_familiesgfx942cache_typenonetest_amdgpu_familiesnoneRun: https://github.com/ROCm/TheRock/actions/runs/30661827641