[Quartz] Add notify_quartz to release workflows - #77
Conversation
|
for the requirement "quartz must be live" we could also disable the job in the meantime in notify_quartz.yml itself? |
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
for the requirement "quartz must be live" we could also disable the job in the meantime in notify_quartz.yml itself?
Sounds good! Anyway, pre-commit needs to be fixed before this can land.
|
per-commit is failing because #75 is not merged yet and notify_quartz.yml does not exist yet. |
…6643) `notify_quartz.yml` is a reusable workflow that runs `notify_quartz.py` from TheRock. We also want to use it for rockrel ( ROCm/rockrel#77 ). To support this, the following is changed: - Pin repo checkout to `ROCm/TheRock` so the notify script is always available regardless of caller. - Bumps `actions/checkout` to v7.0.0 - Use dynamic naming for the `notify` job so runs are identifiable in the Actions UI.
| reporting_workflow: multi_arch_release.yml | ||
| workflow_inputs: ${{ toJSON(inputs) }} | ||
| workflow_captured_outputs: ${{ toJSON(needs) }} | ||
| secrets: inherit |
There was a problem hiding this comment.
| secrets: inherit | |
| secrets: | |
| GH_APP_HAULY_ID: ${{ secrets.GH_APP_HAULY_ID }} | |
| GH_APP_HAULY_PRIVATE_KEY: ${{ secrets.GH_APP_HAULY_PRIVATE_KEY }} |
we should limit this now, rather than addressing later, with one caveat, that the same has to be done in the rock
cgoea
left a comment
cgoea
left a comment
There was a problem hiding this comment.
Apart from the secrets scope being limited to only those needed, LGTM
There was a problem hiding this comment.
What happened here? Line ending change?
There was a problem hiding this comment.
i was also wondering. apparently yes.
see claude analysis:
test_pytorch_wheels_full.yml was the only workflow file committed with CRLF (Windows) line endings, while all other workflows use LF (Unix); this PR normalizes it to LF to match. The large add/delete count on that file is therefore line-ending churn, not logic changes — the only real change is the two notify_quartz jobs.
There was a problem hiding this comment.
You don't need to ask Claude to check for line endings.
There was a problem hiding this comment.
but how do i see here in which direction the line ending changed?
There was a problem hiding this comment.
There are several options to check and then it's pure a pure comparison between the different commits but we can take this offline.
3 participants
Adds Quartz start/completed notifications to each release- and test-related workflow, so
Quartz is informed when a run begins and ends. Uses the
ROCm/Quartz/.github/actions/notify_quartz@maincomposite action, run as standalone jobson
ubuntu-24.04withcontinue-on-error: trueso a notification failure never fails therelease. Captures workflow inputs (and job outputs on completion); the workflow file name
is passed manually via
reporting_workflow, since the GitHub API does not expose it.Gated on a new repo variable
NOTIFY_QUARTZ_ENABLED- Quartz runs only if it is'true'.Prerequisite before merging:
Issue: https://github.com/ROCm/Quartz/issues/19