ci: default PyTorch release wheels to sccache - #83
Open
subodh-dubey-amd wants to merge 3 commits into
Open
Conversation
Align rockrel's Linux/Windows release-wheel wrappers with TheRock, which defaults these builds to sccache since ROCm/TheRock#5471. The wrappers had drifted and still defaulted to none, so release wheels built cold. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
marbre
reviewed
Aug 5, 2026
marbre
left a comment
marbre
left a comment
Member
There was a problem hiding this comment.
Before merging this, can we make sure to remove access to therock-pytorch-sccache-${release_type} from ROCm/TheRock for every release type not dev or at least remove prerelease?
Author
Current trust on the PyTorch sccache roles:
|
Member
@ScottTodd should we remove access to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache_typetosccache(fromnone) in the Linux and Windows PyTorch release-wheel workflows, matching TheRock's release-wheel default.Why
sccache(since Migrate PyTorch sccache to AWS prod account (324352301041, us-east-1) TheRock#5471), and the S3 sccache buckets + OIDC roles fordev/nightly/prereleaseare already provisioned forROCm/rockrel. Enabling it here lets release wheels reuse that cache and speeds up builds.nonestays available for a clean, cache-free build when preferred.Already provisioned (no infra changes needed)
therock-{dev,nightly,prerelease}(acct324352301041) trustROCm/rockrel; bucketstherock-pytorch-sccache-<release_type>exist; both wrappers already grantid-token: write.Notes
workflow_dispatch-only: applies to runs dispatched without an explicitcache_type.