Estimation#17
Conversation
There was a problem hiding this comment.
Part of change to externalize alternative selection (remove hard-coding alt)
There was a problem hiding this comment.
Also removes hard-coding
There was a problem hiding this comment.
ISO format needed for sorting
There was a problem hiding this comment.
IDK what these changes are or if they're up-to-date
There was a problem hiding this comment.
IDK what these changes are or if they're up to date
There was a problem hiding this comment.
Looks like you added this awhile ago: 63da533
I think we can leave the terms in assuming we want to try to estimate things with them, but think we should change the starting coefficients to 0.
There was a problem hiding this comment.
I definitely didn't author these changes - they likely got pulled in from a different branch
There was a problem hiding this comment.
I'll change to 0 though
There was a problem hiding this comment.
IDK what these changes are or if they're up to date
There was a problem hiding this comment.
This ties to @dhensle's comment about adding new coefficient to estimate
There was a problem hiding this comment.
IDK what these changes are or if they're up to date
There was a problem hiding this comment.
These are all labeling updates and one bug fix.
There was a problem hiding this comment.
And they should be incorporated into main, yes?
There was a problem hiding this comment.
IDK what these changes are or if they're up to date
There was a problem hiding this comment.
Again lots of labeling changes. We will have to merge in Joel's changes to this file too.
There was a problem hiding this comment.
And we're OK with incorporating these labeling changes into main?
There was a problem hiding this comment.
This removes the hard-coded alternatives
There was a problem hiding this comment.
Looks like you added this awhile ago: 63da533
I think we can leave the terms in assuming we want to try to estimate things with them, but think we should change the starting coefficients to 0.
There was a problem hiding this comment.
These are all labeling updates and one bug fix.
There was a problem hiding this comment.
Again lots of labeling changes. We will have to merge in Joel's changes to this file too.
There was a problem hiding this comment.
Need a separate spec to remove unavailability conditions in estimation mode (-999 becomes -30) because we have trips where people's modes don't necessarily conform to our expectations
There was a problem hiding this comment.
Need a separate spec to remove unavailability conditions in estimation mode (-999 becomes -30) because we have trips where people's modes don't necessarily conform to our expectations
b098496 to
650b89f
Compare
Changes for estimation mode