fix build with -Wcast-function-type -Werror on gcc8#4
Open
anarcat wants to merge 1 commit into
Open
Conversation
New versions of gcc8 will fail to build from source on Python
declarations because of the hairy cast we're doing there, example:
pam_python.c:1355:19: error: cast between incompatible function types from 'PyObject * (*)(PyObject *, PyObject *, PyObject *)' {aka 'struct _object * (*)(struct _object *, struct _object *, struct _object *)'} to 'PyObject * (*)(PyObject *, PyObject *)' {aka 'struct _object * (*)(struct _object *, struct _object *)'} [-Werror=cast-function-type]
This fix comes form the upstream cpython implementation:
python/cpython@62be742#diff-c3cf251f16d5a03a9e7d4639f2d6f998
|
This is meanwhile fixed upstream: https://sourceforge.net/p/pam-python/code/ci/0247ab687b4347cc52859ca461fb0126dd7e2ebe/tree//src/pam_python.c?diff=ed984bf580e0fc43210e7a9d26fee13af6a57acd in 1.0.7 and part of https://github.com/Ralnoc/pam-python/pull/8/changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New versions of gcc8 will fail to build from source on Python
declarations because of the hairy cast we're doing there, example:
This fix comes form the upstream cpython implementation:
python/cpython@62be742#diff-c3cf251f16d5a03a9e7d4639f2d6f998