fix: do not scan custom wrappers for GleamView.Line - #8
Merged
RamboWasReal merged 1 commit intoAug 27, 2026
Merged
Conversation
Recursive Line detection walked every component's children, so a parent GleamView entered Line mode when those Lines actually belonged to a nested GleamView (or were never mounted). Only View and Fragment are transparent for first-render detection; custom wrappers still register after mount. Co-authored-by: David Boutin <RamboWasReal@users.noreply.github.com>
RamboWasReal
marked this pull request as ready for review
August 27, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression fix for #7 (
cursor/improvements-audit-6a43).scanLineChildrenwalked every component'sprops.children. That is too broad: a parentGleamViewentered Line mode (plainView, no block shimmer) whenGleamView.Lineappeared in a custom wrapper's children even if those Lines:GleamView(nearest-ancestor contract), orOn
main, only direct children and Fragments were inspected; custom wrappers usedregisterLineafter mount. First-render detection is kept for the documented case (<View>/ Fragment). Custom components are left to registration.Repro (before this fix, on #7)
Expected (main + docs): outer stays a native shimmer; Line binds to
inner.Actual on #7:
outerbecame a plain View (loadingundefined) — parent shimmer gone.What changed
React.FragmentandViewNo native iOS/Android changes. No new JS dependencies.
Verification
yarn test— 100 passedyarn typecheckyarn lintyarn prepareResidual risks on #7 (not fixed here — not regressions vs main)
useReduceMotion()startsfalse, then flips async →NativeGleamViewremounts to staticView(ref churn;onTransitionEndnot on the static path)accessibilityStateis applied then overwritten by{...viewProps}(busy is still set on Lines)gleamAccessibilityStateforcesbusy: truewhile loading, including over a callerbusy: false