build: approve scripts we rely on at install time, in prep for npm 12#558
Open
joanise wants to merge 1 commit into
Open
build: approve scripts we rely on at install time, in prep for npm 12#558joanise wants to merge 1 commit into
joanise wants to merge 1 commit into
Conversation
With npm 12, scripts will not run unless they are explicitly approved. See https://docs.npmjs.com/cli/v11/commands/npm-approve-scripts https://ishu.dev/post/npm-install-scripts-opt-in-rfc-prepare-now-2026-05-20
|
Review changes with |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
With npm 12, scripts will not run unless they are explicitly approved.
See
Fixes?
Future proof our installation procedure, although I'm sure it's going to cause trouble when we bump versions in the package lock and forget to bump script approval. But this is where npm is heading, and that's going to make things safer, so we have to adapt to it.
Feedback sought?
Is it OK to blanket all the scripts we run now just like this? I'm figuring at this point we use these and things are OK. These permissions are pinned, so I'm figuring if a supply chain attack compromises something we use, it won't be able to run and we'll get a chance to audit before we update the allow list.
Priority?
low
Tests added?
n/a
How to test?
When you run
npm installon main with a recent version of npm, you'll see this warning:with this PR, that warning is gone.
You can see it in CI on main vs this PR's branch.
Confidence?
medium
Version change?
no