Extract transience calculation logic into reusable helper#36
Merged
Conversation
…ator Both PrimaryPortInnerErrors and SecondaryPortInnerErrors carried a byte-for-byte identical ComputeTransience implementation. Extract that logic into an internal TransienceCalculator helper and have both classes delegate to it, so the transience resolution rules live in a single authoritative place. Behaviour is unchanged; existing coverage in PortInnerErrorsTests exercises all branches through the public API. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011eKgk4tXrcECvpepJwGshF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes the transience resolution logic used by multiple inner-error collections into a dedicated
TransienceCalculatorhelper class. This eliminates code duplication betweenPrimaryPortInnerErrorsandSecondaryPortInnerErrorswhile maintaining a single authoritative implementation.Type of change
Changes
TransienceCalculatorstatic helper class with aCompute(IEnumerable<Error>)method that encapsulates the transience resolution rulesPrimaryPortInnerErrors.ComputeTransience()to delegate toTransienceCalculator.Compute()SecondaryPortInnerErrors.ComputeTransience()to delegate toTransienceCalculator.Compute()Testing
Documentation