Skip to content

fix(slide-builder): brand kit PUT is destructive, not a partial update#12

Open
charliebirch-cmyk wants to merge 1 commit intoRelevanceAI:mainfrom
charliebirch-cmyk:fix/brand-kit-put-destructive-semantics
Open

fix(slide-builder): brand kit PUT is destructive, not a partial update#12
charliebirch-cmyk wants to merge 1 commit intoRelevanceAI:mainfrom
charliebirch-cmyk:fix/brand-kit-put-destructive-semantics

Conversation

@charliebirch-cmyk
Copy link
Copy Markdown

Summary

The "Update Brand Kit" section in relevance-slide-builder/SKILL.md claims "Partial update — only provided fields are changed". That contradicts the destructive-semantics warning already documented in the SE Agent Builder downstream:

  • .claude/rules/universal.md "Brand Kits" section: PUT wipes any array field (colors, logos, inspiration_photos) that is omitted from the body; scalar fields (name, brand_tone, voice, fonts) are preserved. Fix pattern is fetch-merge-save.
  • build-kit/tools/platform-tool-gotchas.md "Brand Kit API": same warning, plus the singular/plural endpoint naming mismatch (GET /branding_kit/{id} vs PUT|DELETE /branding_kits/{id}).

This PR brings the cc-plugin skill docs into alignment so every project consuming this plugin gets the same guidance — not just the SE Agent Builder repo.

Changes

  • Rewrite the "Update Brand Kit" example as fetch-merge-save, with a BAD counter-example showing the partial PUT that wipes arrays.
  • Annotate the Brand Kit Endpoints table with the singular/plural naming inconsistency so future readers don't "fix" it.

Docs-only; no API contract change.

Test plan

  • Render the SKILL.md locally — headings, code fences, table all render correctly
  • Reviewer sanity-check that the fetch-merge-save pattern matches how the rest of the plugin documents destructive PUTs (compare to relevance_save_agent_draft guidance)

🤖 Generated with Claude Code

The "Update Brand Kit" section claimed "Partial update -- only provided
fields are changed". That contradicts the destructive-semantics warning
carried in the downstream SE Agent Builder docs:

- `.claude/rules/universal.md` "Brand Kits" section: PUT wipes any
  array field (colors, logos, inspiration_photos) that is omitted from
  the body; scalar fields (name, brand_tone, voice, fonts) are
  preserved. The fix pattern is fetch-merge-save.
- `build-kit/tools/platform-tool-gotchas.md` "Brand Kit API": same
  warning, with an additional note on the singular/plural endpoint
  naming mismatch (GET is `/branding_kit/{id}`, PUT/DELETE are
  `/branding_kits/{id}`).

Bringing the cc-plugin skill docs into alignment so every project
consuming this plugin gets the same guidance.

Changes:

- Rewrites the "Update Brand Kit" example as fetch-merge-save and adds
  a BAD counter-example showing the partial PUT that wipes arrays.
- Annotates the Brand Kit Endpoints table with the singular/plural
  naming inconsistency so future readers don't "fix" it.

Docs-only; no API contract change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant