fix(slide-builder): brand kit PUT is destructive, not a partial update#12
Open
charliebirch-cmyk wants to merge 1 commit intoRelevanceAI:mainfrom
Open
Conversation
The "Update Brand Kit" section claimed "Partial update -- only provided
fields are changed". That contradicts the destructive-semantics warning
carried in the downstream SE Agent Builder docs:
- `.claude/rules/universal.md` "Brand Kits" section: PUT wipes any
array field (colors, logos, inspiration_photos) that is omitted from
the body; scalar fields (name, brand_tone, voice, fonts) are
preserved. The fix pattern is fetch-merge-save.
- `build-kit/tools/platform-tool-gotchas.md` "Brand Kit API": same
warning, with an additional note on the singular/plural endpoint
naming mismatch (GET is `/branding_kit/{id}`, PUT/DELETE are
`/branding_kits/{id}`).
Bringing the cc-plugin skill docs into alignment so every project
consuming this plugin gets the same guidance.
Changes:
- Rewrites the "Update Brand Kit" example as fetch-merge-save and adds
a BAD counter-example showing the partial PUT that wipes arrays.
- Annotates the Brand Kit Endpoints table with the singular/plural
naming inconsistency so future readers don't "fix" it.
Docs-only; no API contract change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Update Brand Kit" section in
relevance-slide-builder/SKILL.mdclaims "Partial update — only provided fields are changed". That contradicts the destructive-semantics warning already documented in the SE Agent Builder downstream:.claude/rules/universal.md"Brand Kits" section: PUT wipes any array field (colors,logos,inspiration_photos) that is omitted from the body; scalar fields (name,brand_tone,voice, fonts) are preserved. Fix pattern is fetch-merge-save.build-kit/tools/platform-tool-gotchas.md"Brand Kit API": same warning, plus the singular/plural endpoint naming mismatch (GET /branding_kit/{id}vsPUT|DELETE /branding_kits/{id}).This PR brings the cc-plugin skill docs into alignment so every project consuming this plugin gets the same guidance — not just the SE Agent Builder repo.
Changes
Docs-only; no API contract change.
Test plan
relevance_save_agent_draftguidance)🤖 Generated with Claude Code