Remove the Browse all row from the Open page (#185) - #207
Merged
Conversation
"This phone" and "Browse all" launched the identical system picker, and the system picker''s own drawer already reaches every installed DocumentsProvider - the row was a duplicate entry point. The browseAll emit and the App-side handler stay wired so a future row is a template-block re-add; the two locale strings go with the row. The rest of the #185 Phase 1 SAF-first idea is retired deliberately (recorded on the issue): per-provider picker deep links would need the provider roots table, which only holders of the signature-level MANAGE_DOCUMENTS permission can query, and Android/data is sealed by the platform on 11+ (13+ even against All-files access) - neither is reachable from an ordinary app, and the native OneDrive/Google Drive pipelines plus a future WebDAV provider cover the real use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The row duplicated 'This phone' — both launched the identical system picker, whose drawer already reaches every installed DocumentsProvider, so nothing becomes unreachable. The
browseAllemit and the App-side handler stay wired (a future row is a template-block re-add); the two locale strings leave with the row (all ten languages).Deliberately retired with this change (details in the #185 comment): per-provider picker deep links (querying another provider's roots requires the signature-level
MANAGE_DOCUMENTSpermission — ordinary apps cannot build anEXTRA_INITIAL_URIfor arbitrary providers) and any Android/data ambition (sealed by the platform since Android 11, and since 13 even against All-files access; only Shizuku/root-class tools bypass it, which does not fit this app).Verification: web 693 tests green,
vue-tsc -b+ Vite build green, focused lint clean, Open-page e2e spec 7/7 (no test referenced the row).