Reduce always-on diagnostic profiling overhead - #3
Open
Minnona wants to merge 3 commits into
Open
Conversation
Minnona
marked this pull request as ready for review
August 12, 2026 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Diagnostic timing was running around every event dispatch, callback, and oUF tag event even when no profiling session was active. These hooks sit on hot paths, so the diagnostic mechanism itself added persistent overhead.
The profiler also originally queried addon usage by name. Ascension's client returns zero for both name and numeric-index memory queries, so the report now distinguishes unavailable addon accounting from genuine zero usage and provides total Lua memory instead.
Impact
Normal gameplay no longer pays the always-on timing cost. The explicit profiler still captures the character/equipment paths needed to investigate frame-opening stalls and reports meaningful memory data on clients without addon-level accounting.
Validation
git diff --check upstream/main...HEAD/eperfsessions completed without Lua errorsGetAddOnMemoryUsagereturns zero for both ElvUI's addon name and numeric index