Handle chat messages without sender GUIDs - #4
Open
Minnona wants to merge 1 commit into
Open
Conversation
Minnona
marked this pull request as ready for review
August 13, 2026 08:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The class-color path checked
arg12 ~= "", which is also true whenarg12isnil. Ascension chat events can omit Blizzard's optional sender GUID, causingGetPlayerInfoByGUID(nil)to raise a usage error. The later player-name cache protected the API call withpcall, but could still pass its nil realm result tostrmatch.Impact
Chat messages without sender GUID metadata render normally without Lua errors. Messages with valid GUIDs retain their existing class-color and name-cache behavior.
Validation
luac5.1 -p ElvUI/Modules/Chat/Chat.luagit diff --check upstream/main...HEAD