Print blend-transition keys as clip name pairs - #8
Open
DexalGT wants to merge 2 commits into
Open
Conversation
mBlendDataTable packs two clip hashes per u64 key, so animation bins rendered them as 20-digit integers. Match Flint and print the readable From -> To form; the parser already accepts both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnimationGraphData.mBlendDataTableis amap[u64, …]whose keys are not numbers — theu64packs two FNV1a-32 clip hashes (source high, destination low). Quartz rendered them as meaningless 20-digit integers in animation BIN text.tree_to_text_with_hashesnow passesTextOptions { blend_keys: true }, so the printer emitsRun -> Death. Flint already does the same inflint-bin/src/codec.rs.tree_to_text_cached-> that one function, so this is a single change.from_textaccepts the readable pair, the rawu64and the packed-hex dialect unconditionally, sotext_to_treeneeds no flag and the save path round-trips byte-exactly either way.Attack1 -> 0xdeadbeef) and still parses.Also bumps
ritosharkfrom2ed5554to24fe6b3(currentmain, the rev Flint pins), which is what carries the blend-key support.Verified with
cargo test -p quartz-lib --lib --tests(261 passed) andcargo clippy --workspace --lib --bins --tests(clean).Note:
crates/quartz-lib/examples/fbx_*.rsandmktri.rsfail to compile onmainalready (they importfbxcel, which is in no manifest, and a removedmodel_bridge::fbx_writer), so--all-targetsruns need scoping around them.