修复省赛无边界时球门与边界墙穿模的bug - #2
Open
lkhcode wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts SSLWorld wall geometry to avoid boundary-wall/goal clipping when field margins are removed or reduced, and fixes a missing return value in camera positioning.
Changes:
- Splits each vertical boundary wall into upper/lower segments around the goal area.
- Increases
WALL_COUNTfrom 10 to 12 and renumbers goal wall entries. - Adds
return truetoSSLWorld::getCamPos().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/sslworld.cpp |
Updates wall construction geometry and fixes getCamPos() return behavior. |
include/sslworld.h |
Updates wall array count to match the expanded wall set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| walls[2] = new PFixedBox(pos_x, -thick/2, pos_z, | ||
| thick, siz_y, siz_z, | ||
| const double gthick = cfg->Goal_Thickness(); | ||
| const double gpos_y = (cfg->Goal_Width() + gthick) / 2.0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.