refactor(web-ui-registration): remove unnecessary ReactElement type annotations across registration components by tassoevan · Pull Request #40808 · RocketChat/Rocket.Chat

tassoevan · 2026-06-04T15:52:51Z

⚠️ This is part 6/23 of #40796. PR for refactor/prepare-types-for-react-19-5 must be merged first.

Proposed changes (including videos or screenshots)

As a first step towards upgrading to React 19, it handles types from @types/react looking forward the next major.

Issue(s)

Task: ARCH-2170

Steps to test or reproduce

Further comments

No runtime change is expected from it.

Summary by CodeRabbit

Refactor
- Simplified internal type annotations across registration components by removing explicit return type declarations and allowing TypeScript to infer types automatically. No functional or user-facing changes were made to the application.

changeset-bot · 2026-06-04T15:52:56Z

⚠️ No Changeset found

Latest commit: 1be5051

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-06-04T15:53:00Z

Worried about impact? Review this PR in Change Stack to explore blast radius before you approve or request changes.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 840a0c4f-d457-4654-bbea-0aaf13582bff

📥 Commits

Reviewing files that changed from the base of the PR and between cb386e9 and 1be5051.

📒 Files selected for processing (20)

packages/web-ui-registration/src/CMSPage.tsx
packages/web-ui-registration/src/EmailConfirmationForm.tsx
packages/web-ui-registration/src/LoginForm.tsx
packages/web-ui-registration/src/LoginServices.tsx
packages/web-ui-registration/src/LoginServicesButton.tsx
packages/web-ui-registration/src/RegisterForm.tsx
packages/web-ui-registration/src/RegisterFormDisabled.tsx
packages/web-ui-registration/src/RegisterSecretPageRouter.tsx
packages/web-ui-registration/src/RegistrationPageRouter.tsx
packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx
packages/web-ui-registration/src/ResetPasswordForm.tsx
packages/web-ui-registration/src/SecretRegisterForm.tsx
packages/web-ui-registration/src/SecretRegisterInvalidForm.tsx
packages/web-ui-registration/src/components/LoginPoweredBy.tsx
packages/web-ui-registration/src/components/LoginSwitchLanguageFooter.tsx
packages/web-ui-registration/src/components/LoginTerms.tsx
packages/web-ui-registration/src/components/RegisterTitle.tsx
packages/web-ui-registration/src/template/FormSkeleton.tsx
packages/web-ui-registration/src/template/HorizontalTemplate.tsx
packages/web-ui-registration/src/template/VerticalTemplate.tsx

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: 📦 Build Packages
GitHub Check: cubic · AI code reviewer
GitHub Check: Hacktron Security Check
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

packages/web-ui-registration/src/RegisterFormDisabled.tsx
packages/web-ui-registration/src/template/VerticalTemplate.tsx
packages/web-ui-registration/src/SecretRegisterInvalidForm.tsx
packages/web-ui-registration/src/components/LoginPoweredBy.tsx
packages/web-ui-registration/src/SecretRegisterForm.tsx
packages/web-ui-registration/src/components/LoginTerms.tsx
packages/web-ui-registration/src/components/RegisterTitle.tsx
packages/web-ui-registration/src/RegistrationPageRouter.tsx
packages/web-ui-registration/src/ResetPasswordForm.tsx
packages/web-ui-registration/src/LoginServicesButton.tsx
packages/web-ui-registration/src/template/HorizontalTemplate.tsx
packages/web-ui-registration/src/components/LoginSwitchLanguageFooter.tsx
packages/web-ui-registration/src/CMSPage.tsx
packages/web-ui-registration/src/template/FormSkeleton.tsx
packages/web-ui-registration/src/EmailConfirmationForm.tsx
packages/web-ui-registration/src/LoginForm.tsx
packages/web-ui-registration/src/LoginServices.tsx
packages/web-ui-registration/src/RegisterForm.tsx
packages/web-ui-registration/src/RegisterSecretPageRouter.tsx
packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx

🧠 Learnings (6)

📓 Common learnings

Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39676
File: .changeset/migrate-users-register-openapi.md:3-3
Timestamp: 2026-03-16T21:50:42.118Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs, removing endpoint types and validators from `rocket.chat/rest-typings` (e.g., `UserRegisterParamsPOST`, `/v1/users.register` entry) is the *required* migration pattern per RocketChat/Rocket.Chat-Open-API#150 Rule 7 ("No More rest-typings or Manual Typings"). The endpoint type is re-exposed via a module augmentation `.d.ts` file in the consuming package (e.g., `packages/web-ui-registration/src/users-register.d.ts`). This is NOT a breaking change — the correct changeset bump for `rocket.chat/rest-typings` in this scenario is `minor`, not `major`. Do not flag this as a breaking change during OpenAPI migration reviews.

Learnt from: smirk-dev
Repo: RocketChat/Rocket.Chat PR: 39625
File: apps/meteor/app/api/server/v1/push.ts:85-97
Timestamp: 2026-03-14T14:58:58.834Z
Learning: In RocketChat/Rocket.Chat, the `push.token` POST/DELETE endpoints in `apps/meteor/app/api/server/v1/push.ts` were already migrated to the chained router API pattern on `develop` prior to PR `#39625`. `cleanTokenResult` (which strips `authToken` and returns `PushTokenResult`) and `isPushTokenPOSTProps`/`isPushTokenDELETEProps` validators already exist on `develop`. PR `#39625` only migrates `push.get` and `push.info` to the chained pattern. Do not flag `cleanTokenResult` or `PushTokenResult` as newly introduced behavior-breaking changes when reviewing this PR.

Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39647
File: apps/meteor/app/api/server/v1/users.ts:710-757
Timestamp: 2026-03-15T14:31:28.969Z
Learning: In RocketChat/Rocket.Chat, the `UserCreateParamsPOST` type in `apps/meteor/app/api/server/v1/users.ts` (migrated from `packages/rest-typings/src/v1/users/UserCreateParamsPOST.ts`) intentionally has `fields: string` (non-optional) and `settings?: IUserSettings` without a corresponding AJV schema entry. This is a pre-existing divergence carried over verbatim from the original rest-typings source (PR `#39647`). Do not flag this type/schema misalignment during the OpenAPI migration review — it is tracked as a separate follow-up fix.

Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39647
File: apps/meteor/app/api/server/v1/users.ts:891-899
Timestamp: 2026-03-15T14:31:23.493Z
Learning: In RocketChat/Rocket.Chat, `IUser.inactiveReason` in `packages/core-typings/src/IUser.ts` is typed as `'deactivated' | 'pending_approval' | 'idle_too_long'` (optional, no `null`), but the database stores `null` for newly created users. The Typia-generated `$ref: '`#/components/schemas/IUser`'` schema therefore correctly rejects `null` for `inactiveReason`. This causes the test "should create a new user with default roles" to fail when response validation is active (TEST_MODE). The fix is to add `| null` to `inactiveReason` in core-typings and rebuild Typia schemas in a separate PR. Do not flag this test failure as a bug introduced by the users.create OpenAPI migration (PR `#39647`). Do not suggest inlining a custom schema to work around it, as migration rules require using `$ref` when a Typia schema exists.

Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39304
File: packages/ui-contexts/src/ActionManagerContext.ts:26-26
Timestamp: 2026-03-04T14:16:49.202Z
Learning: In `packages/ui-contexts/src/ActionManagerContext.ts` (TypeScript, RocketChat/Rocket.Chat), the `disposeView` method in `IActionManager` uses an intentionally explicit union `UiKit.ModalView['id'] | UiKit.BannerView['viewId'] | UiKit.ContextualBarView['id']` to document which view types are accepted, even though all constituents resolve to the same primitive. The inline `// eslint-disable-next-line typescript-eslint/no-duplicate-type-constituents` comment is intentional and should not be flagged or removed.

📚 Learning: 2026-03-16T21:50:42.118Z

Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39676
File: .changeset/migrate-users-register-openapi.md:3-3
Timestamp: 2026-03-16T21:50:42.118Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs, removing endpoint types and validators from `rocket.chat/rest-typings` (e.g., `UserRegisterParamsPOST`, `/v1/users.register` entry) is the *required* migration pattern per RocketChat/Rocket.Chat-Open-API#150 Rule 7 ("No More rest-typings or Manual Typings"). The endpoint type is re-exposed via a module augmentation `.d.ts` file in the consuming package (e.g., `packages/web-ui-registration/src/users-register.d.ts`). This is NOT a breaking change — the correct changeset bump for `rocket.chat/rest-typings` in this scenario is `minor`, not `major`. Do not flag this as a breaking change during OpenAPI migration reviews.

Applied to files:

packages/web-ui-registration/src/RegisterFormDisabled.tsx
packages/web-ui-registration/src/template/VerticalTemplate.tsx
packages/web-ui-registration/src/SecretRegisterInvalidForm.tsx
packages/web-ui-registration/src/components/LoginPoweredBy.tsx
packages/web-ui-registration/src/SecretRegisterForm.tsx
packages/web-ui-registration/src/components/LoginTerms.tsx
packages/web-ui-registration/src/components/RegisterTitle.tsx
packages/web-ui-registration/src/RegistrationPageRouter.tsx
packages/web-ui-registration/src/ResetPasswordForm.tsx
packages/web-ui-registration/src/LoginServicesButton.tsx
packages/web-ui-registration/src/template/HorizontalTemplate.tsx
packages/web-ui-registration/src/components/LoginSwitchLanguageFooter.tsx
packages/web-ui-registration/src/CMSPage.tsx
packages/web-ui-registration/src/EmailConfirmationForm.tsx
packages/web-ui-registration/src/LoginServices.tsx
packages/web-ui-registration/src/RegisterForm.tsx
packages/web-ui-registration/src/RegisterSecretPageRouter.tsx
packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx

📚 Learning: 2026-03-27T14:52:56.865Z

Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.

Applied to files:

packages/web-ui-registration/src/RegisterFormDisabled.tsx
packages/web-ui-registration/src/template/VerticalTemplate.tsx
packages/web-ui-registration/src/SecretRegisterInvalidForm.tsx
packages/web-ui-registration/src/components/LoginPoweredBy.tsx
packages/web-ui-registration/src/SecretRegisterForm.tsx
packages/web-ui-registration/src/components/LoginTerms.tsx
packages/web-ui-registration/src/components/RegisterTitle.tsx
packages/web-ui-registration/src/RegistrationPageRouter.tsx
packages/web-ui-registration/src/ResetPasswordForm.tsx
packages/web-ui-registration/src/LoginServicesButton.tsx
packages/web-ui-registration/src/template/HorizontalTemplate.tsx
packages/web-ui-registration/src/components/LoginSwitchLanguageFooter.tsx
packages/web-ui-registration/src/CMSPage.tsx
packages/web-ui-registration/src/template/FormSkeleton.tsx
packages/web-ui-registration/src/EmailConfirmationForm.tsx
packages/web-ui-registration/src/LoginForm.tsx
packages/web-ui-registration/src/LoginServices.tsx
packages/web-ui-registration/src/RegisterForm.tsx
packages/web-ui-registration/src/RegisterSecretPageRouter.tsx
packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx

📚 Learning: 2026-05-06T12:21:44.083Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.

Applied to files:

packages/web-ui-registration/src/RegisterFormDisabled.tsx
packages/web-ui-registration/src/template/VerticalTemplate.tsx
packages/web-ui-registration/src/SecretRegisterInvalidForm.tsx
packages/web-ui-registration/src/components/LoginPoweredBy.tsx
packages/web-ui-registration/src/SecretRegisterForm.tsx
packages/web-ui-registration/src/components/LoginTerms.tsx
packages/web-ui-registration/src/components/RegisterTitle.tsx
packages/web-ui-registration/src/RegistrationPageRouter.tsx
packages/web-ui-registration/src/ResetPasswordForm.tsx
packages/web-ui-registration/src/LoginServicesButton.tsx
packages/web-ui-registration/src/template/HorizontalTemplate.tsx
packages/web-ui-registration/src/components/LoginSwitchLanguageFooter.tsx
packages/web-ui-registration/src/CMSPage.tsx
packages/web-ui-registration/src/template/FormSkeleton.tsx
packages/web-ui-registration/src/EmailConfirmationForm.tsx
packages/web-ui-registration/src/LoginForm.tsx
packages/web-ui-registration/src/LoginServices.tsx
packages/web-ui-registration/src/RegisterForm.tsx
packages/web-ui-registration/src/RegisterSecretPageRouter.tsx
packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx

📚 Learning: 2025-11-17T15:07:13.273Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37398
File: packages/fuselage-ui-kit/src/surfaces/FuselageSurfaceRenderer.tsx:357-363
Timestamp: 2025-11-17T15:07:13.273Z
Learning: In packages/fuselage-ui-kit/src/surfaces/FuselageSurfaceRenderer.tsx, IconElement is a presentational, non-actionable element that does not require wrapping in AppIdProvider, similar to plain_text and mrkdwn renderers. Only actionable elements (those with actions, actionId, or interactive behavior) should be wrapped in AppIdProvider.

Applied to files:

packages/web-ui-registration/src/components/LoginPoweredBy.tsx
packages/web-ui-registration/src/LoginServicesButton.tsx

📚 Learning: 2026-03-18T16:08:17.800Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 39590
File: apps/meteor/client/views/omnichannel/contactInfo/EditContactInfo.tsx:97-99
Timestamp: 2026-03-18T16:08:17.800Z
Learning: In `apps/meteor/client/views/omnichannel/contactInfo/EditContactInfo.tsx`, `reValidateMode: 'onBlur'` is intentionally used (not 'onChange') because the `validateEmailFormat` and `validatePhone` functions are async and call the `checkExistenceEndpoint` API to check for duplicates. Using 'onChange' would trigger excessive network requests on every keystroke. The combination of `mode: 'onSubmit'` with `reValidateMode: 'onBlur'` is a deliberate design decision to minimize API calls while still providing revalidation feedback.

Applied to files:

packages/web-ui-registration/src/EmailConfirmationForm.tsx

🔇 Additional comments (20)

packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx (1)

26-26: LGTM!

packages/web-ui-registration/src/ResetPasswordForm.tsx (1)

11-11: LGTM!

packages/web-ui-registration/src/RegisterSecretPageRouter.tsx (1)

19-19: LGTM!

packages/web-ui-registration/src/RegistrationPageRouter.tsx (1)

2-2: LGTM!

Also applies to: 13-13

packages/web-ui-registration/src/template/FormSkeleton.tsx (1)

4-30: LGTM!

packages/web-ui-registration/src/template/HorizontalTemplate.tsx (1)

10-10: LGTM!

Also applies to: 17-17

packages/web-ui-registration/src/template/VerticalTemplate.tsx (1)

4-4: LGTM!

Also applies to: 11-11

packages/web-ui-registration/src/CMSPage.tsx (1)

11-11: LGTM!

packages/web-ui-registration/src/EmailConfirmationForm.tsx (1)

8-8: LGTM!

packages/web-ui-registration/src/LoginForm.tsx (1)

57-57: LGTM!

packages/web-ui-registration/src/RegisterForm.tsx (1)

35-35: LGTM!

packages/web-ui-registration/src/LoginServices.tsx (1)

3-3: LGTM!

Also applies to: 9-9

packages/web-ui-registration/src/LoginServicesButton.tsx (1)

5-5: LGTM!

Also applies to: 26-26

packages/web-ui-registration/src/RegisterFormDisabled.tsx (1)

8-8: LGTM!

packages/web-ui-registration/src/components/LoginPoweredBy.tsx (1)

6-6: LGTM!

packages/web-ui-registration/src/components/LoginSwitchLanguageFooter.tsx (1)

7-7: LGTM!

Also applies to: 44-44

packages/web-ui-registration/src/components/LoginTerms.tsx (1)

7-7: LGTM!

packages/web-ui-registration/src/SecretRegisterForm.tsx (1)

10-10: LGTM!

packages/web-ui-registration/src/SecretRegisterInvalidForm.tsx (1)

5-5: LGTM!

packages/web-ui-registration/src/components/RegisterTitle.tsx (1)

4-4: LGTM!

Walkthrough

This PR systematically removes explicit ReactElement and ReactElement | null return type annotations from 21 React components across the web-ui-registration package, allowing implicit JSX return type inference. All runtime behavior, component logic, and styling remain unchanged.

Changes

Systematic ReactElement type annotation removal

Layer / File(s)	Summary
Core form component signatures `src/CMSPage.tsx`, `src/EmailConfirmationForm.tsx`, `src/LoginForm.tsx`, `src/RegisterForm.tsx`	`CMSPage`, `EmailConfirmationForm`, `LoginForm`, and `RegisterForm` remove explicit `ReactElement` return type annotations and cleanup now-unused `ReactElement` imports.
Login and authentication UI components `src/LoginServices.tsx`, `src/LoginServicesButton.tsx`, `src/components/LoginPoweredBy.tsx`, `src/components/LoginSwitchLanguageFooter.tsx`, `src/components/LoginTerms.tsx`	`LoginServices`, `LoginServicesButton`, `LoginPoweredBy`, `LoginSwitchLanguageFooter`, and `LoginTerms` remove `ReactElement` type annotations from their component signatures; unchanged translation, settings lookup, and rendering logic.
Registration flow and form state components `src/RegisterFormDisabled.tsx`, `src/SecretRegisterForm.tsx`, `src/SecretRegisterInvalidForm.tsx`, `src/components/RegisterTitle.tsx`	`RegisterFormDisabled`, `SecretRegisterForm`, `SecretRegisterInvalidForm`, and `RegisterTitle` remove explicit `ReactElement` annotations from components managing conditional registration states.
Password reset form components `src/ResetPassword/ResetPasswordPage.tsx`, `src/ResetPasswordForm.tsx`	`ResetPasswordPage` and `ResetPasswordForm` remove `ReactElement` return type annotations and consolidate React hook imports.
Router and layout template components `src/RegisterSecretPageRouter.tsx`, `src/RegistrationPageRouter.tsx`, `src/template/FormSkeleton.tsx`, `src/template/HorizontalTemplate.tsx`, `src/template/VerticalTemplate.tsx`	`RegisterSecretPageRouter` and `RegistrationPageRouter` remove `ReactElement` annotations; `FormSkeleton`, `HorizontalTemplate`, and `VerticalTemplate` remove annotations and consolidate to `ReactNode`-only imports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

RocketChat/Rocket.Chat#40807: Applies the same ReactElement return type annotation removal refactor across different components.
RocketChat/Rocket.Chat#40804: Performs identical refactoring pattern of removing ReactElement imports and return-type annotations across another component package.
RocketChat/Rocket.Chat#40805: Systematic removal of explicit ReactElement type annotations from React components in a separate package with no runtime logic changes.

Suggested labels

type: chore

Suggested reviewers

ggazzo
MartinSchoeler

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing ReactElement type annotations from registration components, which aligns with the comprehensive refactoring shown across 25+ files in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (2)

REACT-19: Request failed with status code 401
ARCH-2170: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

dionisio-bot · 2026-06-04T15:53:02Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

codecov · 2026-06-04T16:05:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.06%. Comparing base (cb386e9) to head (1be5051).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #40808      +/-   ##
===========================================
- Coverage    70.07%   70.06%   -0.01%     
===========================================
  Files         3337     3337              
  Lines       123506   123506              
  Branches     22016    22040      +24     
===========================================
- Hits         86548    86539       -9     
+ Misses       33615    33614       -1     
- Partials      3343     3353      +10

Flag	Coverage Δ
e2e	`59.42% <ø> (-0.03%)`	⬇️
e2e-api	`46.24% <ø> (-0.02%)`	⬇️
unit	`70.85% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…nnotations across registration components

cubic-dev-ai

No issues found across 20 files

_{Re-trigger cubic}

refactor(web-ui-registration): remove unnecessary ReactElement type a…

1be5051

…nnotations across registration components

tassoevan force-pushed the refactor/prepare-types-for-react-19-6 branch from 9a2b41b to 1be5051 Compare June 5, 2026 23:44

tassoevan added this to the 8.6.0 milestone Jun 5, 2026

tassoevan requested a review from a team June 5, 2026 23:44

tassoevan marked this pull request as ready for review June 5, 2026 23:44

tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jun 5, 2026

dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 5, 2026

coderabbitai Bot added the type: chore label Jun 5, 2026

cubic-dev-ai Bot reviewed Jun 5, 2026

View reviewed changes

ggazzo approved these changes Jun 7, 2026

View reviewed changes

tassoevan added this pull request to the merge queue Jun 8, 2026

Merged via the queue into develop with commit 67a7d1b Jun 8, 2026
48 checks passed

tassoevan deleted the refactor/prepare-types-for-react-19-6 branch June 8, 2026 14:39

coderabbitai Bot mentioned this pull request Jun 9, 2026

refactor(uikit-playground): remove unnecessary ReactElement type annotations from components #40813

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(web-ui-registration): remove unnecessary ReactElement type annotations across registration components#40808

refactor(web-ui-registration): remove unnecessary ReactElement type annotations across registration components#40808
tassoevan merged 1 commit into
developfrom
refactor/prepare-types-for-react-19-6

tassoevan commented Jun 4, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 4, 2026 •

edited

Loading

Review ran into problems

Uh oh!

dionisio-bot Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tassoevan commented Jun 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Review ran into problems

Uh oh!

dionisio-bot Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tassoevan commented Jun 4, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Jun 4, 2026 •

edited

Loading

coderabbitai Bot commented Jun 4, 2026 •

edited

Loading

dionisio-bot Bot commented Jun 4, 2026 •

edited

Loading

codecov Bot commented Jun 4, 2026 •

edited

Loading