Add standalone single-module profile smoke test - #548
Open
RonaldHensbergen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tests/test_standalone_module_profile.py, a generic smoke test thatdiscovers every
module.yamlundermodules/(andmodules-experimental/,if present) and validates it in isolation.
For each module, the test builds a throwaway single-module
Profilereferencing only that module — no sibling modules, no
dependsOn, nocontract bindings supplied by another module — and runs it through
cli.validator.validate_profile.Modules with a required
consumesentry (e.g. Superset'smetadataDatabase, Dagster'srun-storage) can't resolve that bindingstandalone, so
E030/E041/E042diagnostics are expected and allowlisted.Any other diagnostic code (
E001,E010,E011,E020,E021,E022,...) fails the test, since it indicates a genuine problem with the module's
own definition — invalid YAML, a schema violation in
module.yamlitself,or a malformed
consumes/providesentry.Testing
python -m unittest tests.test_standalone_module_profile -vpython -m unittest discover -s tests -p "test_*.py" -v(full suite, 556 tests, all pass)make lint