docs: formalize images/ independent versioning (middle ground before a repo split) - #550
Open
RonaldHensbergen wants to merge 1 commit into
Open
docs: formalize images/ independent versioning (middle ground before a repo split)#550RonaldHensbergen wants to merge 1 commit into
RonaldHensbergen wants to merge 1 commit into
Conversation
Adds an explicit /images/ CODEOWNERS entry and a Versioning section to docs/image-scanning.md documenting the existing publish-images.yml tag scheme as the authoritative release record for images, and pointing to tests/fixtures/signed-images.json for currently-published digests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #538.
Summary
Per discussion #530, this implements the "middle ground" @SemTiOne
preferred over a full repo split: keep
images/**in this repo, but giveit an explicit CODEOWNERS boundary and formalize its already-existing
independent tag/release cadence.
/images/entry to.github/CODEOWNERS(previously fell through to the repo-wide*default with no distinct line).
docs/image-scanning.mdstating that images are versioned independently of the CLI
(
pyproject.toml/CHANGELOG.md/vX.Y.Ztags cover the CLI only), thatpublish-images.yml's existing tag scheme (base version fromdagster==/apache/superset:/dbt-core==, optionalvariant-prefix,plus
sha-<12>andlatest) is the authoritative release record forimages, and that
tests/fixtures/signed-images.jsonis where to look upthe currently-published digest per image.
Explicitly out of scope (per issue)
publish-images.yml's tag computation itself.Testing
npx --yes markdownlint-cli@0.49.0 "docs/image-scanning.md"— clean.make lint— clean (pre-existing third-party.venvyamllint warningsonly, unrelated to this change).