Show actionable provider error links - #1070
Draft
mrubens wants to merge 1 commit into
Draft
Conversation
Contributor
|
1 issue outstanding. See task
Reviewed ea68b67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The terminal provider-error formatter treated any message containing an HTTP URL as unsafe. That discarded otherwise useful provider guidance and caused the task UI to show only the generic fallback.
Impact
The existing provider-error card can now show the provider's specific explanation and action link while the diagnostic payload remains excluded.
Validation
pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/worker exec vitest run src/sandbox-server/lib/harnesses/__tests__/opencode-server.test.tspnpm --filter @roomote/worker check-typespnpm --filter @roomote/worker lint