[Refactor] Normalize chat reaction task entry - #1110
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
Conversation
Contributor
|
1 issue outstanding. See task
Reviewed 1bbfada |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Introduced one typed reaction task-entry contract for Slack, Discord, and Microsoft Teams. Provider reaction ingress now passes explicit requester, source event, target message/thread, and prompt data into the existing active-task, resume, and fresh-launch orchestration paths instead of forging provider message events.
Discord reactions no longer recurse through a synthetic
MESSAGE_CREATE, Teams reactions no longer mutate activities into messages, and Slack keeps reaction identity separate from the target used for thread context and acknowledgements. Pending Discord account-link requests persist the typed entry so the original reaction intent survives continuation.Why this change was made
Provider event emulation spread reaction-only state through already complex chat handlers and gave the same fields conflicting identity, context, and acknowledgement roles. An explicit boundary keeps future task-entry modes from requiring more synthetic provider payloads and optional state.
Impact
There is no intended user-facing behavior change. Configured chat reactions continue to queue follow-ups, resume eligible tasks, or launch new tasks with the same prompt and target context, while the orchestration is now typed, consistent across providers, and easier to extend safely.