[Chore] Add workflow regression coverage - #1144
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
Conversation
Contributor
![roomote-community[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
| '`explain-repo-code` for understanding, explanation, and code-reading questions', | ||
| ); | ||
| expect(harnessInstructions).toContain( | ||
| 'Unless the request begins with an explicit skill invocation, always start with one of `implement-changes`, `plan-repo-implementation`, or `explain-repo-code`.', |
Contributor
There was a problem hiding this comment.
This only checks that the three existing workflow names remain present. It still passes if a fourth initial-routing option is added, even though the contract requires exactly these three. Please assert the initial-routing menu/cardinality (or otherwise reject additional first-hop workflows) so this regression test protects the stated invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The global identity prompt was recently narrowed to identity and personality while workflow policy moved to dedicated runtime layers. These tests protect the intended split and catch routing or delivery regressions without restoring duplicated prompt behavior.
Impact
There is no runtime behavior change. Future prompt and workflow edits will fail focused tests if they drop Roomote identity, bypass required workflow routing, or stop before confirmed draft PR delivery.