[Chore] Harden suggested task reaction launches - #1148
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Chore] Harden suggested task reaction launches#1148roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Suggestion reactions should behave consistently across chat surfaces and remain idempotent when duplicate webhook deliveries or simultaneous reactions contend for the same work item.
Impact
Linked users continue to launch suggestions normally, while unlinked Slack users now receive a link-account prompt without consuming the suggestion. Concurrent reactions produce one winning launch and leave duplicate attempts as no-ops. Focused tests and the repository pre-push checks pass; the full API ESLint command remains blocked by five pre-existing unused-disable warnings in unrelated tests.