Skip to content

[Chore] Remediate focused dependency security alerts - #1178

Merged
mrubens merged 2 commits into
developfrom
fix/dependabot-security-bundle-0n4gzw9dou0t6
Aug 9, 2026
Merged

[Chore] Remediate focused dependency security alerts#1178
mrubens merged 2 commits into
developfrom
fix/dependabot-security-bundle-0n4gzw9dou0t6

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. View the task or mention @roomote-roomote for follow-up asks.

What changed

  • Updated DOMPurify from 3.4.12 to 3.4.13 for worker HTML sanitization and Mermaid's transitive sanitizer.
  • Updated PDF.js from 5.7.284 to 6.2.108 for attachment text extraction.
  • Updated Mermaid from 11.15.0 to 11.16.1, nanoid 3.x from 3.3.16 to 3.3.17, and js-yaml from 3.15.0/4.3.0 to 3.15.1/4.3.1.
  • Preserved minimumReleaseAge: 10080 without adding package exclusions for these security updates.

Why this change was made

The previous dependency graph contained known XSS, arbitrary JavaScript execution, denial-of-service, prototype-pollution, CSS-injection, and tooling CPU-exhaustion vulnerabilities. This focused bundle moves only the affected packages and their required transitive graphs to GitHub's first patched versions while keeping the existing dependency release-age policy unchanged.

Alert coverage

Impact

User-facing Mermaid rendering, worker widget sanitization, PDF attachment processing, and the affected build/test tooling now resolve patched dependency versions. The focused lockfile no longer contains the vulnerable versions covered by alerts #85 through #95, and no new minimum-release-age exclusions are introduced.

Validation completed with a frozen forced workspace install, full lint and type checks, knip, worker and web production builds, PDF.js parser smoke coverage, 617 cloud-agent tests, 1,672 worker tests, targeted DOMPurify and Mermaid-adjacent tests, and live web/API liveness checks. The follow-up removal of the exclusions also passed a frozen install and the full pre-push static suite. The broad test run initially hit unrelated five-second timeouts in five web tests and two worker tests; every timed-out test passed on isolated or serial rerun with additional time.

@roomote-community

roomote-community Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 37ed187

@mrubens

mrubens commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

@roomote can we avoid adding more min-age exclusions?

@roomote-community

Copy link
Copy Markdown
Contributor

I'm on it. I started a dedicated PR follow-up task for this request, and I'll keep updates here. See task

@roomote-community

roomote-community Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Removed the new dompurify, mermaid, and nanoid minimum-release-age exclusions while keeping their patched versions locked. The frozen install and pre-push static suite pass in 37ed187d, and the PR description now reflects the unchanged policy. See task · Revert commit

@mrubens

mrubens commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

@roomote review now

@roomote-community

Copy link
Copy Markdown
Contributor

I started a PR review task for this request. See task

@mrubens
mrubens marked this pull request as ready for review August 9, 2026 03:59
@mrubens
mrubens merged commit 725986b into develop Aug 9, 2026
20 checks passed
@mrubens
mrubens deleted the fix/dependabot-security-bundle-0n4gzw9dou0t6 branch August 9, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant