[Feat] Send self-hosted Roomote errors to Sentry - #1181
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Feat] Send self-hosted Roomote errors to Sentry#1181roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
|
1 issue outstanding. See task
Reviewed d827a17 |
Contributor
Author
|
Updated the PR to one supported operator-facing |
|
|
||
| import { | ||
| isWebSentryEnabled, | ||
| resolveWebSentryDsn, |
Contributor
There was a problem hiding this comment.
The new import is not reflected in src/__tests__/instrumentation.test.ts, which manually mocks @/lib/sentry-config without resolveWebSentryDsn. As a result all three instrumentation tests now fail at register() with Vitest's missing-export error. Add the resolver to that mock (and ideally assert the resolved DSN) so the web test suite remains runnable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SENTRY_DSNacross production Compose, installer, and Coolify service contracts.Why this change was made
Roomote's services already contained Sentry instrumentation, but standard self-hosted deployment contracts did not pass a configured DSN into those services. Ephemeral task workers also dropped it at the controller-to-worker boundary, so worker errors could not reach the operator's Sentry project.
Impact
Self-hosted operators can set
SENTRY_DSNonce to report server-side web, API, controller, BullMQ, and task-worker errors. RuntimeNEXT_PUBLIC_*injection was removed because Next.js browser values are fixed when the web image is built, not when its container starts.All supported Compose shapes rendered successfully during deployment validation. The later Caddy adaptation check could not run because this sandbox does not expose a Docker socket; focused tests, static checks, documentation validation, and pre-push checks passed.