Skip to content

feat(builds): implement builds list and show methods - #86

Merged
Ryank90 merged 1 commit into
feat/runserv-507from
feat/runserv-506
Aug 18, 2026
Merged

feat(builds): implement builds list and show methods#86
Ryank90 merged 1 commit into
feat/runserv-507from
feat/runserv-506

Conversation

@Ryank90

@Ryank90 Ryank90 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Implements the serverless builds list and show endpoints

@Ryank90
Ryank90 marked this pull request as draft August 14, 2026 17:09
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: acbb081b-96e8-4b9b-bef4-935b14292dda

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in the Runware CLI for inspecting serverless application builds by wiring new apps builds commands to newly exposed Serverless API endpoints, plus display helpers and docs.

Changes:

  • Introduces runware serverless apps builds list and runware serverless apps builds show, including table/JSON/YAML rendering and optional log-tail printing.
  • Extends the serverless API client with ListBuilds and GetBuild, with corresponding unit tests.
  • Updates generated command reference docs to include the new builds command group.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/cmd/serverless/display.go Adds build/builds table renderers and optional int formatting for exit codes.
internal/cmd/serverless/display_test.go Adds tests ensuring build tables omit log columns and render nil optional fields as empty.
internal/cmd/serverless/apps.go Registers the new apps builds command group under serverless apps.
internal/cmd/serverless/apps_builds.go Implements CLI commands for listing/showing builds and printing log tail for table output.
internal/api/serverless/client.go Adds ListBuilds/GetBuild wrappers around generated OpenAPI client calls.
internal/api/serverless/client_test.go Adds unit tests for the new builds endpoints (success, not-found, no-api-key).
docs/runware_serverless_apps.md Links the new builds command group in the apps command docs.
docs/runware_serverless_apps_builds.md Adds docs page for apps builds group.
docs/runware_serverless_apps_builds_list.md Adds docs page for apps builds list.
docs/runware_serverless_apps_builds_show.md Adds docs page for apps builds show.
Suppressed comments (1)

internal/cmd/serverless/apps_builds.go:122

  • To keep table output and the appended log tail on the same stream, write to os.Stdout (which is what output.Print uses) rather than cmd.OutOrStdout().
	_, err := fmt.Fprintf(cmd.OutOrStdout(), "\nLog tail:\n%s\n", *b.LogTail)
	return err

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread internal/cmd/serverless/apps_builds.go
@Ryank90
Ryank90 marked this pull request as ready for review August 18, 2026 14:02

if c.logger != nil && c.logger.Enabled(ctx, slog.LevelDebug) {
c.logger.Debug("serverless response", //nolint:errcheck,gosec
"path", "/v1/deployments/"+deploymentID+"/builds",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: a path literal here will be brittle to upstream changes (e.g. like the big deployments/app rename)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this PR as-is so we don't rebase the stack.

Follow-up at the tip: #93logResponse now takes the generated client's HTTPResponse and logs Request.URL.Path, so a deployments/apps rename tracks OpenAPI regen instead of duplicated literals.

@Ryank90
Ryank90 merged commit 2a4bcab into rc/serverless Aug 18, 2026
4 checks passed
@Ryank90
Ryank90 deleted the feat/runserv-506 branch August 18, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants