feat: apps list filters - #88
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds filter/sort support to the runware serverless apps list command, including better pagination UX by echoing back the active filters alongside the --cursor next-page hint. It also expands the serverless API client’s error handling for ListDeployments to surface 400/422 problem details cleanly.
Changes:
- Added
--query,--gpu-type, and--sortflags toserverless apps list, plus shared parsing/validation helpers for enum-like flags. - Improved cursor pagination hints to include relevant filter flags (with safe quoting for non-bare values).
- Extended
ListDeploymentsclient handling for HTTP 400 and 422 responses, with new tests and updated CLI docs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/cmd/serverless/apps.go | Adds list filters/sort, validates enum flags, and includes filters in next-page cursor hints |
| internal/cmd/serverless/display_test.go | Adds unit tests for sort/status parsing and cursor-hint flag formatting/quoting |
| internal/api/serverless/client.go | Handles 400 and 422 problem+json responses for ListDeployments |
| internal/api/serverless/client_test.go | Verifies new query params are sent and that 400/422 map into RunwareError messages |
| docs/runware_serverless_apps_list.md | Documents the new flags and updated cursor guidance |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
5fcb321 to
4484337
Compare
No description provided.