Skip to content

feat: apps list filters - #88

Merged
Ryank90 merged 3 commits into
feat/runserv-506from
feat/runserv-515
Aug 18, 2026
Merged

feat: apps list filters#88
Ryank90 merged 3 commits into
feat/runserv-506from
feat/runserv-515

Conversation

@Ryank90

@Ryank90 Ryank90 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b8155ec-5aa7-4147-a9d8-5344cead4fba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds filter/sort support to the runware serverless apps list command, including better pagination UX by echoing back the active filters alongside the --cursor next-page hint. It also expands the serverless API client’s error handling for ListDeployments to surface 400/422 problem details cleanly.

Changes:

  • Added --query, --gpu-type, and --sort flags to serverless apps list, plus shared parsing/validation helpers for enum-like flags.
  • Improved cursor pagination hints to include relevant filter flags (with safe quoting for non-bare values).
  • Extended ListDeployments client handling for HTTP 400 and 422 responses, with new tests and updated CLI docs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/cmd/serverless/apps.go Adds list filters/sort, validates enum flags, and includes filters in next-page cursor hints
internal/cmd/serverless/display_test.go Adds unit tests for sort/status parsing and cursor-hint flag formatting/quoting
internal/api/serverless/client.go Handles 400 and 422 problem+json responses for ListDeployments
internal/api/serverless/client_test.go Verifies new query params are sent and that 400/422 map into RunwareError messages
docs/runware_serverless_apps_list.md Documents the new flags and updated cursor guidance

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Ryank90
Ryank90 marked this pull request as ready for review August 18, 2026 13:52
@Ryank90
Ryank90 merged commit b9a1415 into rc/serverless Aug 18, 2026
4 checks passed
@Ryank90
Ryank90 deleted the feat/runserv-515 branch August 18, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants