feat(scale): implement scale methods for apps - #91
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds support for scaling serverless “apps” by introducing an apps scale command that PATCHes live worker configuration via a new Serverless API client method, and enhances single-deployment display output to include scaling-related configuration.
Changes:
- Implement
runware serverless apps scale <appId>with flags mapped to a partial worker-config patch body. - Add
Client.UpdateDeployment(...)and exported type aliases needed for update/patch payloads. - Expand single-deployment table display to include worker configuration fields; add/update tests and generated docs.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/cmd/serverless/display.go | Switch single-deployment table output to Field/Value and include worker configuration/scaling fields. |
| internal/cmd/serverless/display_test.go | Add coverage for deploymentResult output including configuration fields; minor test constant reuse. |
| internal/cmd/serverless/deploy.go | Add optionalFlagStringPtr helper for “include empty string if flag explicitly set” semantics. |
| internal/cmd/serverless/apps.go | Wire apps scale into the apps command tree (replacing prior stub). |
| internal/cmd/serverless/apps_scale.go | New apps scale command implementation and flag→patch construction. |
| internal/cmd/serverless/apps_scale_test.go | New unit tests ensuring each scale flag produces exactly one JSON patch field and that at least one flag is required. |
| internal/api/serverless/client.go | Add exported aliases for update-related types and implement UpdateDeployment. |
| internal/api/serverless/client_test.go | Add tests for UpdateDeployment request shape, success path, 422 mapping, and missing API key. |
| docs/runware_serverless_apps_scale.md | Update generated command docs with synopsis, expanded examples, and options list. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
96a77ed to
3880fe5
Compare
3880fe5 to
03806ae
Compare
No description provided.