Skip to content

fix(payments-adapter-ecpay): correct form html unexpected type error#55

Open
ender503 wants to merge 1 commit into
mainfrom
fix/correct-form-html-unexpected-type-error
Open

fix(payments-adapter-ecpay): correct form html unexpected type error#55
ender503 wants to merge 1 commit into
mainfrom
fix/correct-form-html-unexpected-type-error

Conversation

@ender503

@ender503 ender503 commented Dec 31, 2024

Copy link
Copy Markdown
Contributor

After querying to retrieve the ECPay order and using formHtml() in the production stage, this.form will be undefined.

@ender503
ender503 requested a review from fantasywind December 31, 2024 21:14
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying utils-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d08aa9e
Status: ✅  Deploy successful!
Preview URL: https://e3a939df.utils-docs.pages.dev
Branch Preview URL: https://fix-correct-form-html-unexpe.utils-docs.pages.dev

View logs

@fantasywind

Copy link
Copy Markdown
Member

I think we should use OrderState to determine whether the data was returned from a query, and if so, not provide the form/formHTML functionality, rather than resolving it in such a brute-force way.
Also, please make sure to add the corresponding unit test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants