fix: possible race condition sending wss packets - #1016
Merged
Conversation
vladimir-a-sap
enabled auto-merge (squash)
August 31, 2026 17:19
vladimir-a-sap
changed the title
…-java into stabilize-speech-to-speech-ci
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
Contributor
There was a problem hiding this comment.
Would you need to change the Javadoc to indicate that the API is blocking or was this already the expectation?
Contributor
Author
no, the exposed api signatures are all sync, no changes there or in the docs are needed |
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
Jonas-Isr
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / Cause
Fix
ws.send(...)replaced withws.send(...).join()in client.send(...)