fix: Handle contextMode in RptClient - #1020
Merged
Merged
Conversation
Jonas-Isr
changed the title
vladimir-a-sap
previously approved these changes
Sep 1, 2026
vladimir-a-sap
left a comment
vladimir-a-sap
left a comment
Contributor
There was a problem hiding this comment.
discussed the tradeoffs, seems like a balanced approach to avoid breaking changes for our users
vladimir-a-sap
force-pushed
the
fix-rpt-tests-jonas
branch
from
September 1, 2026 14:17
a457399 to
a057cd6
Compare
vladimir-a-sap
force-pushed
the
fix-rpt-tests
branch
from
September 1, 2026 14:17
a249d71 to
0fdf703
Compare
vladimir-a-sap
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I added some logic to
RptClientto setcontextModeto null whenever a version before 1.6 is used.E2E tests run green for me on this locally.