Skip to content

buildsystem: fix the macOS build (Eigen 5 + Apple clang) #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheJJ merged 2 commits into from
May 30, 2026
+8 −5
Merged

buildsystem: fix the macOS build (Eigen 5 + Apple clang) #1801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f7169b
libopenage: accept Eigen 5 by relaxing version pin
nickk02 May 29, 2026
fb16286
ci: build the macOS job with Apple clang
nickk02 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/macosx-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ jobs:
run: brew install --cask font-dejavu
- name: Install environment helpers with homebrew
run: brew install --force ccache
- name: Install LLVM with homebrew
run: brew install --force llvm
- name: Install openage dependencies with homebrew
run: brew install --force cmake python3 libepoxy freetype fontconfig harfbuzz opus opusfile qt6 libogg libpng toml11 eigen
- name: Install nyan dependencies with homebrew
Expand All @@ -56,7 +54,7 @@ jobs:
# numpy pulls gcc as dep? and pygments doesn't work.
run: pip3 install --upgrade --break-system-packages cython numpy mako lz4 pillow pygments setuptools toml
- name: Configure
run: ./configure --compiler="$(brew --prefix llvm)/bin/clang++" --mode=release --ccache --download-nyan
run: ./configure --compiler=clang --mode=release --ccache --download-nyan
- name: Build
run: make -j$(sysctl -n hw.logicalcpu) VERBOSE=1
- name: Test
Expand Down
9 changes: 7 additions & 2 deletions libopenage/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2014-2025 the openage authors. See copying.md for legal info.
# Copyright 2014-2026 the openage authors. See copying.md for legal info.

# main C++ library definitions.
# dependency and source file setup for the resulting library.
Expand Down Expand Up @@ -56,7 +56,12 @@ find_package(PNG REQUIRED)
find_package(Opusfile REQUIRED)
find_package(Epoxy REQUIRED)
find_package(HarfBuzz 1.0.0 REQUIRED)
find_package(Eigen3 3.3 REQUIRED NO_MODULE)
# Eigen dropped strict config-version compatibility across its 3 to 5 major
# bump, so pinning "3.3" here makes find_package reject Eigen 5 (shipped by
# Arch and Homebrew) even though openage only uses the stable core/geometry
# API. A version range would need cmake 3.19; our floor is 3.16, so require
# any Eigen3 config instead.
find_package(Eigen3 REQUIRED NO_MODULE)

set(CMAKE_THREAD_PREFER_PTHREAD TRUE)
find_package(Threads REQUIRED)
Expand Down
Loading