feat(osmAG): add standalone C++ build, AlphaRemoval noise cleaning, CGAL safety checks, and visual stage export - #2
Open
abdulrahimzulfiqar wants to merge 1 commit into
Conversation
…al noise cleaning, and CGAL safety checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This Pull Request resolves standalone build errors, fixes fatal CGAL precondition crashes on noisy maps, restores missing furniture noise pre-processing from the 2019 Area Graph paper, and adds automated visual stage image export.
1. Standalone Build & Dependency Resolution (
ag_osm_generator&osmAG)Qt5::Widgets,Qt5::Gui), CGAL, OpenCV, Eigen3, and PCL.ag_osm_generatorto enable clean standalone C++ building without legacy ROS 1 catkin dependencies.2. Restored
performAlphaRemovalNoise Cleaningag_osm_generator/src/AreaGenerate.cpp, added#include "cgal/AlphaShapeRemoval.h"and invokedperformAlphaRemoval().clean.pngprior to Voronoi site generation, reducing fragmented 48-polygon decompositions into clean room boundaries.3. CGAL Assertion & Crash Safeguards (
is_simple())ag_osm_generator/src/cgal/CgalVoronoi.cpp, wrapped calls topolygon.bounded_side(p)withpolygon.is_simple()checks.CGAL::Precondition_exception: is_simple()abort errors.4. Automated Visual Stage Image Export
roomGraph.png): Updatedag_osm_generator/src/Area_osm.cppto automatically save color-coded Voronoi room segmentation maps with red topological room-center nodes.osmAG/src/data_load_save.cppto iterate through all leaf area cells (InitOccupancyMap_Area) and export 2D Occupancy Grid Submap images (<map_name>_stage2_room_submap_<1..N>.png).osmAG/src/visualization.cppwith auto-scaled canvas math to render prominent magenta global A* path trajectories, start/goal markers, and passage graph overlays.5. Flexible Command-Line Output Path
ag_osm_generator/test/test_osm_generation.cppto accept an optional 10th argument (argv[10]) specifying the custom target.osmXML path.6. Documentation & Build Guides
README.mdandag_osm_generator/ReadMewith system architecture diagrams, macOS/Ubuntu prerequisites, argument reference tables (explaining effective door widthVerification & Testing
big_map_7_cleaned.png: 8 leaf submaps, 4 rooms, 74 A* waypoints).Freiburg79_scan_furnitures_trashbins.png: 44 leaf submaps, 21 passages, 319 A* waypoints over 32.98m).