fix: rename stem_and_suffix to stem_and_affix in tests#6
Open
bitflicker64 wants to merge 1 commit into
Open
Conversation
stem_and_suffix does not exist in core/forms/utils.py or anywhere else in the codebase. The correct function name is stem_and_affix. Affected files: - tests/test_adoption.py: fix import and 3 call sites - tests/test_agent.py: fix 1 call site - tests/test_compression.py: fix 2 call sites - tests/test_induction.py: fix 2 call sites Signed-off-by: Himanshu Verma <himnshuverma10152006@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
stem_and_suffixdoes not exist anywhere in the codebase. The correct function name isstem_and_affix, defined incore/forms/utils.py.Problem
tests/test_adoption.pyfails at import time withImportError: cannot import name 'stem_and_suffix' from 'core.forms.utils'tests/test_agent.py,tests/test_compression.py, andtests/test_induction.pyfail at runtime withAttributeError: module 'core.forms.morphology' has no attribute 'stem_and_suffix'Fix
Rename all 9 occurrences of
stem_and_suffix→stem_and_affixacross the four affected test files. No production code is changed. The function signature is identical —(form) -> (stem, affixes).Files changed
tests/test_adoption.pytests/test_agent.pytests/test_compression.pytests/test_induction.py.gitignore.idea/stem_and_suffixdoes not exist — tests fail withImportError/AttributeError#5