Skip to content

feat(share): support custom publishing helpers - #1106

Merged
SamSaffron merged 3 commits into
SamSaffron:mainfrom
sam-saffron-jarvis:feat/gist-auth-active-account
Sep 3, 2026
Merged

feat(share): support custom publishing helpers#1106
SamSaffron merged 3 commits into
SamSaffron:mainfrom
sam-saffron-jarvis:feat/gist-auth-active-account

Conversation

@sam-saffron-jarvis

@sam-saffron-jarvis sam-saffron-jarvis commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • fix GitHub authentication checks to validate only the active account and keep CLI diagnostics out of user-facing errors
  • introduce a provider-neutral transcript sharing layer with GitHub Gist as the zero-config default
  • add the versioned term-llm-share command-helper protocol for private/custom publishers
  • make Web, TUI, CLI, persistence, visibility, readiness, and error UX provider-aware
  • retain legacy GitHub request/response and persisted-state compatibility
  • add sessions share while leaving explicit session/agent Gist commands intact
  • document the helper contract and configuration

Safety and compatibility

  • helper execution is argv-only, bounded, timed out, process-group cleaned, and isolated in a private temporary bundle
  • helper IDs/URLs/capabilities are validated; github is reserved for the built-in provider
  • helper and gh stderr is bounded and operator-only, never returned to Web/TUI users
  • response/conversation Web shares remain non-persisted; only whole-session shares can be updated
  • legacy GitHub share fields are normalized and dual-written without a database migration
  • raw reasoning is opt-in for generic CLI/TUI sharing and remains excluded from Web sharing

Review

  • protocol/spec reviewed with Fable before implementation
  • implementation reviewed with Opus; all blocking and practical medium findings were addressed, including ErrWaitDelay, relative helper paths, provider impersonation, readiness, capability caching, visibility correctness, diagnostics, raw-reasoning disclosure, and regression coverage

Verification

  • focused sharing/config/Gist/session/TUI/cmd Go suites pass
  • go vet ./...
  • frontend format, lint, typecheck, and all 581 tests pass
  • mise x node@24 -- make build
  • git diff --check

Local focused suites, frontend checks, vet, and the canonical build pass. GitHub CI’s test and race jobs currently fail in the pre-existing flaky TestServeShellProcessGroupCleanup test (the shell prints an empty background PID); passkey-smoke independently times out locating its second-key Rename button. The sharing packages/tests pass, and cross-build/frontend checks are green.

@sam-saffron-jarvis sam-saffron-jarvis changed the title fix(gist): validate the active GitHub account feat(share): support custom publishing helpers Sep 3, 2026
@sam-saffron-jarvis
sam-saffron-jarvis force-pushed the feat/gist-auth-active-account branch from 75a088b to fcdb9f7 Compare September 3, 2026 08:31
@SamSaffron
SamSaffron merged commit 21c2bff into SamSaffron:main Sep 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants