fix: A hung Git hook wedges commit operations and can survive server restart - #1108
Open
sam-saffron-jarvis wants to merge 1 commit into
Open
fix: A hung Git hook wedges commit operations and can survive server restart#1108sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
git commitsubprocess to a generous five-minute deadline without making an admitted commit depend on client cancellation.WaitDelayso inherited output pipes cannot keepWaitblocked.Why this is high-value
Both web and TUI commit workflows use this host-owned transaction path, and it holds the checkout mutex plus the outer mutation lease while Git runs. Previously, a malformed hook or stuck signing/helper process could wait forever, permanently blocking later commits and coordinated root mutations for that checkout and preventing clean server shutdown. The bounded process-group execution turns that indefinite checkout outage into a classified, recoverable failure while retaining commit-outcome verification.
Validation
gofmt -w internal/gitcommit/process.go internal/gitcommit/gitcommit_test.gogo build ./...(passed after generating the ignored frontend assets required bygo:embed)go test ./internal/gitcommit -run 'TestCommitTimesOutHungHookAndReleasesCheckout|TestUnbornHookFailureIsRecoverableNotUncertain' -count=1go test ./internal/gitcommit -count=3go test -race ./internal/gitcommit -count=1go test ./...in a clean user environment: every package passed except the unrelated existinginternal/serveui.TestProductionBundleSizeBudgets; current generatedapp.js/app.cssgzip sizes exceed main's budgets by 130/291 bytes. This change does not touch frontend sources or bundle budgets.git diff --check